You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by Martin Koci <Ma...@aura.cz> on 2006/09/26 08:34:35 UTC
Re: [jira] Commented: (ADFFACES-196) Allow using of compression
(of names) for user suplied CSS class names
Yes, I uploaded that patch only for clarifying this issue.
Btw. coding conventions - those at
http://wiki.apache.org/myfaces/coding?
And how to test such patch, is everything what I need to know at
http://wiki.apache.org/myfaces/Trinidad_RenderKit_test_framework?
Thanks,
Martin
Adam Winer (JIRA) píše v Po 25. 09. 2006 v 14:54 -0700:
> [ http://issues.apache.org/jira/browse/ADFFACES-196?page=comments#action_12437674 ]
>
> Adam Winer commented on ADFFACES-196:
> -------------------------------------
>
> The overhead of running styleClass.split() on every request seems too much, esp. since the 99% case is when a user only specifies one styleclass. This should be optimized. (Also, the patch doesn't use Trinidad code style conventions).
>
> > Allow using of compression (of names) for user suplied CSS class names
> > ----------------------------------------------------------------------
> >
> > Key: ADFFACES-196
> > URL: http://issues.apache.org/jira/browse/ADFFACES-196
> > Project: MyFaces ADF-Faces
> > Issue Type: Bug
> > Reporter: Martin Koci
> > Attachments: FormInputRenderer.java.patch
> >
> >
> > For now if user supplied CSS class names in styleClass attribute it works as following:
> > styleClass="styleClass1" - output in HTML is "x1n" (for example)
> > styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
> > Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split styleClass values and pass it in renderStyleClasses.
>
Re: [jira] Commented: (ADFFACES-196) Allow using of compression (of names) for user suplied CSS class names
Posted by Simon Lessard <si...@gmail.com>.
They are wikified : http://wiki.apache.org/myfaces/coding
Regards,
~ Simon
On 9/26/06, Adam Winer <aw...@gmail.com> wrote:
>
> For testing, the important thing is just running the maven build, which
> will run the test framework.
>
> Our coding conventions aren't on a Wiki - they should be! The
> one thing I noticed is that we always use "{" on a new line.
>
> -- Adam
>
>
> On 9/26/06, Martin Koci <Ma...@aura.cz> wrote:
> >
> > Yes, I uploaded that patch only for clarifying this issue.
> >
> > Btw. coding conventions - those at
> > http://wiki.apache.org/myfaces/coding?
> >
> > And how to test such patch, is everything what I need to know at
> > http://wiki.apache.org/myfaces/Trinidad_RenderKit_test_framework?
> >
> > Thanks,
> >
> > Martin
> >
> >
> > Adam Winer (JIRA) píše v Po 25. 09. 2006 v 14:54 -0700:
> > > [
> >
> http://issues.apache.org/jira/browse/ADFFACES-196?page=comments#action_12437674
> ]
> > >
> > > Adam Winer commented on ADFFACES-196:
> > > -------------------------------------
> > >
> > > The overhead of running styleClass.split() on every request seems too
> > much, esp. since the 99% case is when a user only specifies one
> > styleclass. This should be optimized. (Also, the patch doesn't use
> > Trinidad code style conventions).
> > >
> > > > Allow using of compression (of names) for user suplied CSS class
> names
> > > >
> ----------------------------------------------------------------------
> > > >
> > > > Key: ADFFACES-196
> > > > URL:
> http://issues.apache.org/jira/browse/ADFFACES-196
> > > > Project: MyFaces ADF-Faces
> > > > Issue Type: Bug
> > > > Reporter: Martin Koci
> > > > Attachments: FormInputRenderer.java.patch
> > > >
> > > >
> > > > For now if user supplied CSS class names in styleClass attribute it
> > works as following:
> > > > styleClass="styleClass1" - output in HTML is "x1n" (for example)
> > > > styleClass="styleClass1 styleClass2" - output is "styleClass1
> > styleClass2"
> > > > Problem is in FormInputRenderer.renderRootDomElementStyles - this
> > method should split styleClass values and pass it in renderStyleClasses.
> > >
> >
> >
>
>
Re: [jira] Commented: (ADFFACES-196) Allow using of compression (of names) for user suplied CSS class names
Posted by Adam Winer <aw...@gmail.com>.
For testing, the important thing is just running the maven build, which
will run the test framework.
Our coding conventions aren't on a Wiki - they should be! The
one thing I noticed is that we always use "{" on a new line.
-- Adam
On 9/26/06, Martin Koci <Ma...@aura.cz> wrote:
>
> Yes, I uploaded that patch only for clarifying this issue.
>
> Btw. coding conventions - those at
> http://wiki.apache.org/myfaces/coding?
>
> And how to test such patch, is everything what I need to know at
> http://wiki.apache.org/myfaces/Trinidad_RenderKit_test_framework?
>
> Thanks,
>
> Martin
>
>
> Adam Winer (JIRA) píše v Po 25. 09. 2006 v 14:54 -0700:
> > [
> http://issues.apache.org/jira/browse/ADFFACES-196?page=comments#action_12437674]
> >
> > Adam Winer commented on ADFFACES-196:
> > -------------------------------------
> >
> > The overhead of running styleClass.split() on every request seems too
> much, esp. since the 99% case is when a user only specifies one
> styleclass. This should be optimized. (Also, the patch doesn't use
> Trinidad code style conventions).
> >
> > > Allow using of compression (of names) for user suplied CSS class names
> > > ----------------------------------------------------------------------
> > >
> > > Key: ADFFACES-196
> > > URL: http://issues.apache.org/jira/browse/ADFFACES-196
> > > Project: MyFaces ADF-Faces
> > > Issue Type: Bug
> > > Reporter: Martin Koci
> > > Attachments: FormInputRenderer.java.patch
> > >
> > >
> > > For now if user supplied CSS class names in styleClass attribute it
> works as following:
> > > styleClass="styleClass1" - output in HTML is "x1n" (for example)
> > > styleClass="styleClass1 styleClass2" - output is "styleClass1
> styleClass2"
> > > Problem is in FormInputRenderer.renderRootDomElementStyles - this
> method should split styleClass values and pass it in renderStyleClasses.
> >
>
>