You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by cd...@apache.org on 2008/10/28 09:40:31 UTC

svn commit: r708479 - in /hadoop/core/trunk: CHANGES.txt src/core/org/apache/hadoop/ipc/Server.java

Author: cdouglas
Date: Tue Oct 28 01:40:30 2008
New Revision: 708479

URL: http://svn.apache.org/viewvc?rev=708479&view=rev
Log:
HADOOP-4525. Fix ipc.server.ipcnodelay originally missed in in HADOOP-2232.
Contributed by Clint Morgan.

Modified:
    hadoop/core/trunk/CHANGES.txt
    hadoop/core/trunk/src/core/org/apache/hadoop/ipc/Server.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=708479&r1=708478&r2=708479&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Tue Oct 28 01:40:30 2008
@@ -1040,6 +1040,9 @@
     and can be used with other Serialization frameworks. (Chris Wensel via
     acmurthy)
 
+    HADOOP-4525. Fix ipc.server.ipcnodelay originally missed in in HADOOP-2232.
+    (cdouglas via Clint Morgan)
+
 Release 0.18.2 - Unreleased
 
   BUG FIXES

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/ipc/Server.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/ipc/Server.java?rev=708479&r1=708478&r2=708479&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/ipc/Server.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/ipc/Server.java Tue Oct 28 01:40:30 2008
@@ -136,7 +136,7 @@
 
   private int maxQueueSize;
   private int socketSendBufferSize;
-  private boolean tcpNoDelay; // if T then disable Nagle's Algorithm
+  private final boolean tcpNoDelay; // if T then disable Nagle's Algorithm
 
   volatile private boolean running = true;         // true while server runs
   private BlockingQueue<Call> callQueue; // queued calls
@@ -955,6 +955,7 @@
     this.port = listener.getAddress().getPort();    
     this.rpcMetrics = new RpcMetrics(serverName,
                           Integer.toString(this.port), this);
+    this.tcpNoDelay = conf.getBoolean("ipc.server.tcpnodelay", false);
 
 
     // Create the responder here