You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 15:03:03 UTC

[GitHub] [arrow-rs] jhorstmann opened a new pull request #1290: Fix bitmask creation also for simd comparisons with scalar

jhorstmann opened a new pull request #1290:
URL: https://github.com/apache/arrow-rs/pull/1290


   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #1285 (now also for comparisons with a scalar).
   
   # Rationale for this change
    
   Followup to #1286, which only fixed the bitmask creation for comparing two arrays, but missed the same bug when comparing with a scalar.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb merged pull request #1290: Fix bitmask creation also for simd comparisons with scalar

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1290:
URL: https://github.com/apache/arrow-rs/pull/1290


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] jhorstmann commented on pull request #1290: Fix bitmask creation also for simd comparisons with scalar

Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #1290:
URL: https://github.com/apache/arrow-rs/pull/1290#issuecomment-1033929291


   For reference, before the fix tests with the larger inputs tests would fail like this:
   
   ```
   ---- compute::kernels::comparison::tests::test_primitive_array_eq_scalar stdout ----
   thread 'compute::kernels::comparison::tests::test_primitive_array_eq_scalar' panicked at 'assertion failed: `(left == right)`
     left: `BooleanArray
   [
     false,
     false,
     true,
     false,
     false,
     false,
     false,
     true,
     false,
     false,
     ...80 elements...,
     false,
     false,
     true,
     false,
     false,
     false,
     false,
     true,
     false,
     false,
   ]`,
    right: `BooleanArray
   [
     false,
     false,
     true,
     true,
     true,
     true,
     true,
     true,
     true,
     true,
     ...80 elements...,
     false,
     false,
     true,
     false,
     false,
     false,
     false,
     true,
     false,
     false,
   ]`', arrow/src/compute/kernels/comparison.rs:2518:9
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] jhorstmann commented on pull request #1290: Fix bitmask creation also for simd comparisons with scalar

Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #1290:
URL: https://github.com/apache/arrow-rs/pull/1290#issuecomment-1033857366


   Noticed by @JasonLi-cn and @alamb in <https://github.com/apache/arrow-rs/commit/411171ac7ad3efe9391b2a0f8709f7fe97672a20>. Sorry again for missing this earlier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1290: Fix bitmask creation also for simd comparisons with scalar

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1290:
URL: https://github.com/apache/arrow-rs/pull/1290#issuecomment-1033881120


   Thanks @jhorstmann  -- I'll get this in and spin up a new RC 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org