You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/10/09 08:31:17 UTC
[GitHub] [incubator-linkis] binbinCheng opened a new pull request, #3602: [linkis-engineconn-plugin-core]module errorcode optimization and docu…
binbinCheng opened a new pull request, #3602:
URL: https://github.com/apache/incubator-linkis/pull/3602
**[linkis-engineconn-plugin-core ]module errorcode optimization and documentation**
Related issues: #3373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #3602: [linkis-engineconn-plugin-core]module errorcode optimization and docu…
Posted by GitBox <gi...@apache.org>.
casionone merged PR #3602:
URL: https://github.com/apache/incubator-linkis/pull/3602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3602: [linkis-engineconn-plugin-core]module errorcode optimization and docu…
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3602:
URL: https://github.com/apache/incubator-linkis/pull/3602#discussion_r995454676
##########
linkis-computation-governance/linkis-engineconn/linkis-engineconn-plugin-core/src/main/java/org/apache/linkis/manager/engineplugin/errorcode/EngineconnCoreErrorCodeSummary.java:
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.manager.engineplugin.errorcode;
+
+public enum EngineconnCoreErrorCodeSummary {
+ FAILED_CREATE_ELR(
+ 10001,
+ "Failed to createEngineConnLaunchRequest(未能创建EngineConnLaunchRequest)",
+ "Failed to createEngineConnLaunchRequest(未能创建EngineConnLaunchRequest)"),
+ ETL_REQUESTED(
+ 10001,
+ "EngineTypeLabel are requested(请求 EngineTypeLabel)",
+ "EngineTypeLabel are requested(请求 EngineTypeLabel)"),
+ CANNOT_INSTANCE_ECE(
+ 20000,
+ "Cannot instance EngineConnExecution(无法实例 EngineConnExecution)",
+ "Cannot instance EngineConnExecution(无法实例 EngineConnExecution)"),
+
+ CANNOT_DEFAULT_EF(
+ 20000,
+ "Cannot find default ExecutorFactory(找不到默认的 ExecutorFactory)",
+ "Cannot find default ExecutorFactory(找不到默认的 ExecutorFactory)"),
+ ETL_NOT_EXISTS(
+ 20000,
+ "EngineTypeLabel is not exists(EngineTypeLabel 不存在)",
+ "EngineTypeLabel is not exists(EngineTypeLabel 不存在)"),
+ UCL_NOT_EXISTS(
+ 20000,
+ "UserCreatorLabel is not exists(UserCreatorLabel 不存在)",
+ "UserCreatorLabel is not exists(UserCreatorLabel 不存在)"),
+ CANNOT_HOME_PATH_EC(
+ 20001,
+ "Cannot find the home path of engineConn(找不到engineConn的home路径)",
+ "Cannot find the home path of engineConn(找不到engineConn的home路径)"),
+ CANNOT_HOME_PATH_DIST(
+ 20001,
+ "Cannot find the home path of engineconn dist(找不到 engineconn dist 的home路径)",
+ "Cannot find the home path of engineconn dist(找不到 engineconn dist 的home路径)"),
+ DIST_IS_EMPTY(
+ 20001,
+ "The dist of EngineConn is empty,engineConnType(EngineConn 的 dist 为空,engineConnType):",
+ "The dist of EngineConn is empty,engineConnType(EngineConn 的 dist 为空,engineConnType):"),
+ DIST_IRREGULAR_EXIST(
+ 20001,
+ "The dist of EngineConn is irregular, both the version dir and non-version dir are exist,engineConnType(EngineConn的dist是不规则的，版本目录和非版本目录都存在,engineConnType):",
+ "The dist of EngineConn is irregular, both the version dir and non-version dir are exist,engineConnType(EngineConn的dist是不规则的，版本目录和非版本目录都存在,engineConnType):"),
+ NO_PERMISSION_FILE(
+ 20001,
+ "System have no permission to delete old engineConn file,File(系统无权删除旧的engineConn文件,File):",
+ "System have no permission to delete old engineConn file,File(系统无权删除旧的engineConn文件,File):"),
+ LIB_CONF_DIR_NECESSARY(
+ 20001,
+ "The `lib` and `conf` dir is necessary in EngineConn dist,engineConnType(`lib` 和 `conf` 目录在 EngineConn dist 中是必需的,engineConnType):",
+ "The `lib` and `conf` dir is necessary in EngineConn dist,engineConnType(`lib` 和 `conf` 目录在 EngineConn dist 中是必需的,engineConnType):"),
+
+ NOT_SUPPORTED_EF(
+ 20011,
+ "Not supported ExecutorFactory(不支持 ExecutorFactory)",
+ "Not supported ExecutorFactory(不支持 ExecutorFactory)"),
+ DERTL_CANNOT_NULL(
+ 70101,
+ "DefaultEngineRunTypeLabel cannot be null(DefaultEngineRunTypeLabel 不能为空)",
+ "DefaultEngineRunTypeLabel cannot be null(DefaultEngineRunTypeLabel 不能为空)"),
+ CANNOT_GET_LABEL_KEY(
+ 70102,
+ "Cannot get label key. labels (无法获取标签密钥,标签):",
Review Comment:
无法获取标签密钥 ->无法获取标签key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #3602: [linkis-engineconn-plugin-core]module errorcode optimization and docu…
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #3602:
URL: https://github.com/apache/incubator-linkis/pull/3602#issuecomment-1272499016
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/3602?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3602](https://codecov.io/gh/apache/incubator-linkis/pull/3602?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b6065e) into [dev-1.3.1](https://codecov.io/gh/apache/incubator-linkis/commit/2afadfc2420c8cd6ea563517e52649a4b8d771d1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2afadfc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## dev-1.3.1 #3602 +/- ##
===============================================
- Coverage 13.78% 13.76% -0.02%
Complexity 1307 1307
===============================================
Files 876 877 +1
Lines 33820 33870 +50
Branches 4914 4914
===============================================
+ Hits 4661 4662 +1
- Misses 28505 28554 +49
Partials 654 654
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/3602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ugin/errorcode/EngineconnCoreErrorCodeSummary.java](https://codecov.io/gh/apache/incubator-linkis/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWVuZ2luZWNvbm4vbGlua2lzLWVuZ2luZWNvbm4tcGx1Z2luLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9lcnJvcmNvZGUvRW5naW5lY29ubkNvcmVFcnJvckNvZGVTdW1tYXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gineplugin/common/creation/EngineConnFactory.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWVuZ2luZWNvbm4vbGlua2lzLWVuZ2luZWNvbm4tcGx1Z2luLWNvcmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vY29tbW9uL2NyZWF0aW9uL0VuZ2luZUNvbm5GYWN0b3J5LnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...h/process/JavaProcessEngineConnLaunchBuilder.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWVuZ2luZWNvbm4vbGlua2lzLWVuZ2luZWNvbm4tcGx1Z2luLWNvcmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vY29tbW9uL2xhdW5jaC9wcm9jZXNzL0phdmFQcm9jZXNzRW5naW5lQ29ubkxhdW5jaEJ1aWxkZXIuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...aunch/process/ProcessEngineConnLaunchBuilder.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWVuZ2luZWNvbm4vbGlua2lzLWVuZ2luZWNvbm4tcGx1Z2luLWNvcmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vY29tbW9uL2xhdW5jaC9wcm9jZXNzL1Byb2Nlc3NFbmdpbmVDb25uTGF1bmNoQnVpbGRlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...ommon/resource/AbstractEngineResourceFactory.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWVuZ2luZWNvbm4vbGlua2lzLWVuZ2luZWNvbm4tcGx1Z2luLWNvcmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vY29tbW9uL3Jlc291cmNlL0Fic3RyYWN0RW5naW5lUmVzb3VyY2VGYWN0b3J5LnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...r/engineplugin/python/executor/PythonSession.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9weXRob24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vcHl0aG9uL2V4ZWN1dG9yL1B5dGhvblNlc3Npb24uc2NhbGE=) | `58.91% <0.00%> (ø)` | |
| [...a/org/apache/linkis/scheduler/queue/Consumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvQ29uc3VtZXIuc2NhbGE=) | `100.00% <0.00%> (+14.28%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3602: [linkis-engineconn-plugin-core]module errorcode optimization and docu…
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3602:
URL: https://github.com/apache/incubator-linkis/pull/3602#discussion_r995457003
##########
linkis-computation-governance/linkis-engineconn/linkis-engineconn-plugin-server/src/main/scala/org/apache/linkis/engineplugin/server/service/DefaultEngineConnLaunchService.scala:
##########
@@ -72,12 +73,15 @@ class DefaultEngineConnLaunchService extends EngineConnLaunchService with Loggin
t
)
throw new EngineConnPluginErrorException(
- 10001,
- s"Failed to createEngineConnLaunchRequest, ${ExceptionUtils.getRootCauseMessage(t)}"
+ FAILED_CREATE_ELR.getErrorCode,
+ FAILED_CREATE_ELR.getErrorDesc + s", ${ExceptionUtils.getRootCauseMessage(t)}"
Review Comment:
+s ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3602: [linkis-engineconn-plugin-core]module errorcode optimization and docu…
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3602:
URL: https://github.com/apache/incubator-linkis/pull/3602#discussion_r995457003
##########
linkis-computation-governance/linkis-engineconn/linkis-engineconn-plugin-server/src/main/scala/org/apache/linkis/engineplugin/server/service/DefaultEngineConnLaunchService.scala:
##########
@@ -72,12 +73,15 @@ class DefaultEngineConnLaunchService extends EngineConnLaunchService with Loggin
t
)
throw new EngineConnPluginErrorException(
- 10001,
- s"Failed to createEngineConnLaunchRequest, ${ExceptionUtils.getRootCauseMessage(t)}"
+ FAILED_CREATE_ELR.getErrorCode,
+ FAILED_CREATE_ELR.getErrorDesc + s", ${ExceptionUtils.getRootCauseMessage(t)}"
Review Comment:
+s ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org