You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@artemis.apache.org by "gtully (via GitHub)" <gi...@apache.org> on 2026/03/20 10:56:06 UTC
[PR] ARTEMIS-5958 refactor security store to expose hasPermission bool, to… [artemis]
gtully opened a new pull request, #6309:
URL: https://github.com/apache/artemis/pull/6309
… get a fast path for rbac chechs that restrict access. the regular check is still in play for invocations
Assisted-by: Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5958 refactor security store to expose hasPermission bool, to… [artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on PR #6309:
URL: https://github.com/apache/artemis/pull/6309#issuecomment-4288376014
@jbertram I am not reproducing any failure with repeated test runs, jdk 21. what jdk are you seeing the failure in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5958 refactor security store to expose hasPermission bool, to… [artemis]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on PR #6309:
URL: https://github.com/apache/artemis/pull/6309#issuecomment-4155214512
There's a lack of tests here that cover the new split out hasPermissions API which would seems like something we'd want to add. I know the new API is called from the old check method now but it would seem like testing in isolation the new API would be prudent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5958 refactor security store to expose hasPermission bool, to… [artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram merged PR #6309:
URL: https://github.com/apache/artemis/pull/6309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5958 refactor security store to expose hasPermission bool, to… [artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on PR #6309:
URL: https://github.com/apache/artemis/pull/6309#issuecomment-4161062414
good call, added some more test coverage for the new and existing api to protect it into the future. thanks @tabish121 for taking a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5958 refactor security store to expose hasPermission bool, to… [artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #6309:
URL: https://github.com/apache/artemis/pull/6309#issuecomment-4285733761
Looks like `org.apache.activemq.artemis.core.security.impl.SecurityStoreImplTest#testManagementAuthorizationAfterNullAuthenticationFailure` is failing on `main` now. Can you take a look, @gtully?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5958 refactor security store to expose hasPermission bool, to… [artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #6309:
URL: https://github.com/apache/artemis/pull/6309#issuecomment-4288764673
@gtully false alarm. Sorry about that. I reverted your commit and the test still fails. I'm running on Java 25. I've seen a few security-related tests failing on Java 25. It must be a quirk of the `org.apache.activemq.artemis.utils.sm.SecurityManagerShim`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org