[jira] [Commented] (SLING-4059) Sling Models: ResourceResolverInjector is obsolete

["Stefan Seifert (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288407#comment-14288407 ] 

Stefan Seifert commented on SLING-4059:
---------------------------------------

Completed: At revision: 1654095  

removed it from documentation as well

> Sling Models: ResourceResolverInjector is obsolete
> --------------------------------------------------
>
>                 Key: SLING-4059
>                 URL: https://issues.apache.org/jira/browse/SLING-4059
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Sling Models Implementation 1.1.0
>            Reporter: Stefan Seifert
>            Assignee: Stefan Seifert
>            Priority: Minor
>             Fix For: Sling Models Impl 1.2.0
>
>         Attachments: remove-resourceresolver-injector.patch
>
>
> the "ResourceResolverInjector" can be considered as obsolete since Sling Models 1.1 because it is superseded by the "SlingObjectInjector"
> attached is a patch that removes it and redirects the unit test to "SlingObjectInjector": [^remove-resourceresolver-injector.patch]
> there should be no problem witch backward compatibility - save one (rather hypothetical) issue: the ResourceResolverInjector checks only for the field name "resourceResolver", and not for the class. so if a user has defined a field of type "Object" named "resourceResolver" it worked with ResourceResolverInjector, but will not work with SlingObjectInjector. but i suppose this would be a very uncommon usage.
> [~justinedelson] please decide if we can remove the ResourceResolverInjector  or should leave it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)