You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/15 08:49:16 UTC
[GitHub] [doris] yiguolei opened a new pull request, #15107: [refactor](fe) remove non vectorized code in fe
yiguolei opened a new pull request, #15107:
URL: https://github.com/apache/doris/pull/15107
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1356239027
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #15107:
URL: https://github.com/apache/doris/pull/15107#discussion_r1056013062
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -318,9 +318,10 @@ private void setFromUserProperty(Analyzer analyzer) {
private void initQueryOptions(ConnectContext context) {
this.queryOptions = context.getSessionVariable().toThrift();
- this.queryOptions.setEnableVectorizedEngine(VectorizedUtil.isVectorized());
+ this.queryOptions.setEnableVectorizedEngine(true);
this.queryOptions.setEnablePipelineEngine(VectorizedUtil.isPipeline());
this.queryOptions.setBeExecVersion(Config.be_exec_version);
+ this.queryOptions.setEnableVectorizedEngine(true);
Review Comment:
duplicate code.
And I think we should forcibly set `EnableVectorizedEngine` to true, not just set true here.
Because `initQueryOptions(ConnectContext context)` is not always called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1352834788
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.2 seconds
load time: 479 seconds
storage size: 17123356890 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221215101105_clickbench_pr_63891.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1354154578
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1606350238
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1357484842
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1357237223
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1354502184
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #15107: [refactor](fe) remove non vectorized code in fe
URL: https://github.com/apache/doris/pull/15107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #15107:
URL: https://github.com/apache/doris/pull/15107#discussion_r1050778324
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/VectorizedUtil.java:
##########
@@ -20,18 +20,9 @@
import org.apache.doris.qe.ConnectContext;
public class VectorizedUtil {
Review Comment:
Why not just remove this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1357012752
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1357490385
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1354630436
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #15107:
URL: https://github.com/apache/doris/pull/15107#discussion_r1051401054
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/VectorizedUtil.java:
##########
@@ -20,18 +20,9 @@
import org.apache.doris.qe.ConnectContext;
public class VectorizedUtil {
Review Comment:
because many code depend on isVectorized Method, too many modifications and may remove some if else clause. I am afraid some mistakes. So that I just return true here and may modify these code later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1365527354
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1352738965
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1357012735
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15107: [refactor](fe) remove non vectorized code in fe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15107:
URL: https://github.com/apache/doris/pull/15107#issuecomment-1352891552
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org