You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/10/12 17:02:23 UTC

[GitHub] [hbase] joshelser commented on a change in pull request #3743: HBASE-26350 Add a DEBUG when we fail the SASL handshake

joshelser commented on a change in pull request #3743:
URL: https://github.com/apache/hbase/pull/3743#discussion_r727332522



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java
##########
@@ -372,6 +372,7 @@ public void saslReadAndProcess(ByteBuff saslToken) throws IOException,
         replyToken = saslServer.evaluateResponse(saslToken.hasArray()?
             saslToken.array() : saslToken.toBytes());
       } catch (IOException e) {
+        RpcServer.LOG.debug("Failed to execute SASL handshake", e);

Review comment:
       Yup! slf4j largely prevents this from being an expensive call (the pain is often concatenating the strings together).
   
   Thanks for looking!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org