[GitHub] [maven] gnodet commented on a diff in pull request #998: Using Set<>() for contains()

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on code in PR #998:
URL: https://github.com/apache/maven/pull/998#discussion_r1121322576


##########
maven-core/src/main/java/org/apache/maven/ReactorReader.java:
##########
@@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader {
 
     public static final String PROJECT_LOCAL_REPO = "project-local-repo";
 
-    private static final Collection<String> COMPILE_PHASE_TYPES =
-            Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", "sar", "wsr", "har", "app-client");
+    private static final Set<String> COMPILE_PHASE_TYPES;
+
+    static {
+        COMPILE_PHASE_TYPES = new HashSet<>(
+                Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", "sar", "wsr", "har", "app-client"));
+    }

Review Comment:
   I think what @michael-o meant is that we can keep the `Collection<String>` instead of changing the type to `Set<String>`:
   ```
   private static final Collection<String> COMPILE_PHASE_TYPES =
                new HashSet<>(Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", "sar", "wsr", "har", "app-client"));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org