You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Szehon Ho <sz...@cloudera.com> on 2013/11/01 21:38:32 UTC
Review Request 15187: HIVE-5611 Add assembly (i.e.) tar creation to pom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15187/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
Add src and bin descriptors to maven packaging project.
Src.tar has the entire Hive source tree as is, following Apache src.tar format. Decided not to use <moduleSet> as maven only gives option to prepend the module name, which is different than the directory name in thise case.
Bin.tar still does not include hcatalog stuff. It uses mvn assembly fileset to do what the ant package tasks of hive/build.xml used to do. It also uses maven's <dependencySet> to pull in dependency jars. But hive/hcatalog had a separate ant build, and there is more effort needed to include that into this mvn bin assembly in the correct directory structure.
Diffs
-----
packaging/pom.xml 973b351
packaging/src/main/assembly/bin.xml PRE-CREATION
packaging/src/main/assembly/src.xml PRE-CREATION
Diff: https://reviews.apache.org/r/15187/diff/
Testing
-------
Thanks,
Szehon Ho
Re: Review Request 15187: HIVE-5611 Add assembly (i.e.) tar creation to pom
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15187/#review28036
-----------------------------------------------------------
Great work!! This is a great start. I think we'll figure out the hcatalog stuff in a follow-on jira. I just have a few issues below mostly related to indenting.
packaging/pom.xml
<https://reviews.apache.org/r/15187/#comment54531>
Let's put this in a profile called "dist". Here is an example of profiles:
https://github.com/apache/hive/blob/trunk/odbc/pom.xml#L56
packaging/pom.xml
<https://reviews.apache.org/r/15187/#comment54529>
Let's un-comment these for now
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54521>
The key=value's should be indented
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54522>
id, formats, baseDir are all indented incorrectly
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54520>
If you extract the binary tar it has a weird second directory. Therefore I think this should just be ./
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54524>
this includes indenting is wrong
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54517>
trailing ws
packaging/src/main/assembly/src.xml
<https://reviews.apache.org/r/15187/#comment54527>
same indenting issues as above
packaging/src/main/assembly/src.xml
<https://reviews.apache.org/r/15187/#comment54525>
trailing ws
packaging/src/main/assembly/src.xml
<https://reviews.apache.org/r/15187/#comment54526>
indenting is off here
packaging/src/main/assembly/src.xml
<https://reviews.apache.org/r/15187/#comment54528>
We cannot just exclude the temp stores as opposed to including src?
- Brock Noland
On Nov. 1, 2013, 8:38 p.m., Szehon Ho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15187/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 8:38 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add src and bin descriptors to maven packaging project.
>
> Src.tar has the entire Hive source tree as is, following Apache src.tar format. Decided not to use <moduleSet> as maven only gives option to prepend the module name, which is different than the directory name in thise case.
>
> Bin.tar still does not include hcatalog stuff. It uses mvn assembly fileset to do what the ant package tasks of hive/build.xml used to do. It also uses maven's <dependencySet> to pull in dependency jars. But hive/hcatalog had a separate ant build, and there is more effort needed to include that into this mvn bin assembly in the correct directory structure.
>
>
> Diffs
> -----
>
> packaging/pom.xml 973b351
> packaging/src/main/assembly/bin.xml PRE-CREATION
> packaging/src/main/assembly/src.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15187/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Szehon Ho
>
>
Re: Review Request 15187: HIVE-5611 Add assembly (i.e.) tar creation to pom
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15187/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 10:58 p.m.)
Review request for hive.
Changes
-------
Incorporated review feedback.
Repository: hive-git
Description
-------
Add src and bin descriptors to maven packaging project.
Src.tar has the entire Hive source tree as is, following Apache src.tar format. Decided not to use <moduleSet> as maven only gives option to prepend the module name, which is different than the directory name in thise case.
Bin.tar still does not include hcatalog stuff. It uses mvn assembly fileset to do what the ant package tasks of hive/build.xml used to do. It also uses maven's <dependencySet> to pull in dependency jars. But hive/hcatalog had a separate ant build, and there is more effort needed to include that into this mvn bin assembly in the correct directory structure.
Diffs (updated)
-----
packaging/pom.xml 973b351
packaging/src/main/assembly/bin.xml PRE-CREATION
packaging/src/main/assembly/src.xml PRE-CREATION
Diff: https://reviews.apache.org/r/15187/diff/
Testing
-------
Thanks,
Szehon Ho
Re: Review Request 15187: HIVE-5611 Add assembly (i.e.) tar creation to pom
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15187/#review28044
-----------------------------------------------------------
packaging/pom.xml
<https://reviews.apache.org/r/15187/#comment54552>
Done, I added the profile to control this execution, inside this packaging pom. Let me know if thats not what you had in mind.
I suppose we need to change the wiki for this. Before in ant, running ant package would result in build/ folder for users to run the executables. In mvn, user needs to enable -Pdist before they can get a /packaging/target dist for them to use.
packaging/pom.xml
<https://reviews.apache.org/r/15187/#comment54567>
I removed these. If I uncomment them, these project's dependencies get pulled into the bin. These cause a lot of classpath issues, like for example same jar but different version, and also pulling in xerces xml parsing that is incompatible with hive startup.
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54551>
Done
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54565>
Done
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54566>
Done
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54553>
Done, used <includeBaseDirectory> = false on both src and bin descriptors, to get rid of the second directory.
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54554>
Done.
packaging/src/main/assembly/bin.xml
<https://reviews.apache.org/r/15187/#comment54557>
Done.
packaging/src/main/assembly/src.xml
<https://reviews.apache.org/r/15187/#comment54559>
Done
packaging/src/main/assembly/src.xml
<https://reviews.apache.org/r/15187/#comment54562>
Done
packaging/src/main/assembly/src.xml
<https://reviews.apache.org/r/15187/#comment54563>
Done
packaging/src/main/assembly/src.xml
<https://reviews.apache.org/r/15187/#comment54564>
Changed.
- Szehon Ho
On Nov. 1, 2013, 8:38 p.m., Szehon Ho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15187/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 8:38 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add src and bin descriptors to maven packaging project.
>
> Src.tar has the entire Hive source tree as is, following Apache src.tar format. Decided not to use <moduleSet> as maven only gives option to prepend the module name, which is different than the directory name in thise case.
>
> Bin.tar still does not include hcatalog stuff. It uses mvn assembly fileset to do what the ant package tasks of hive/build.xml used to do. It also uses maven's <dependencySet> to pull in dependency jars. But hive/hcatalog had a separate ant build, and there is more effort needed to include that into this mvn bin assembly in the correct directory structure.
>
>
> Diffs
> -----
>
> packaging/pom.xml 973b351
> packaging/src/main/assembly/bin.xml PRE-CREATION
> packaging/src/main/assembly/src.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15187/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Szehon Ho
>
>