[GitHub] [rocketmq] dongeforever commented on a diff in pull request #4439: [ISSUE #4435] Code optimization for ConsumeQueue abstraction.

[GitBox <gi...@apache.org>]

dongeforever commented on code in PR #4439:
URL: https://github.com/apache/rocketmq/pull/4439#discussion_r905869793


##########
store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java:
##########
@@ -425,9 +425,9 @@ public long getMinOffsetInQueue() {
     }
 
     @Override
-    public void putMessagePositionInfoWrapper(DispatchRequest request) {
+    public void dispatch(DispatchRequest request) {
         final int maxRetries = 30;

Review Comment:
   No good to change this, just respect the history.



##########
store/src/main/java/org/apache/rocketmq/store/queue/BatchConsumeQueue.java:
##########
@@ -445,9 +445,9 @@ public void correctMinOffset(long phyMinOffset) {
     }
 
     @Override
-    public void putMessagePositionInfoWrapper(DispatchRequest request) {
+    public void dispatch(DispatchRequest request) {

Review Comment:
   No good too.



##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -258,7 +249,7 @@ public boolean parseDelayLevel() {
 
     @Override
     public void truncateDirtyLogicFiles(long phyOffset) {
-        this.consumeQueueStore.truncateDirty(phyOffset);
+        this.consumeQueueStore.truncateDirtyFiles(phyOffset);
     }

Review Comment:
   No good to change this too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org