[GitHub] [kafka] dajac commented on a change in pull request #8816: MINOR: Print all members during join complete

[GitBox <gi...@apache.org>]

dajac commented on a change in pull request #8816:
URL: https://github.com/apache/kafka/pull/8816#discussion_r436131739



##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -1186,6 +1185,8 @@ class GroupCoordinator(val brokerId: Int,
           for (member <- group.allMemberMetadata) {
             val joinResult = JoinGroupResult(
               members = if (group.isLeader(member.memberId)) {
+                info(s"Reply the group leader with the following dynamic members' metadata: ${group.allDynamicMembers}" +
+                  s"and static members' metadata: ${group.allStaticMembers}")

Review comment:
       Shouldn't we include the group id in the log as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org