You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Mamta Satoor <ma...@Remulak.Net> on 2005/01/05 18:19:27 UTC

Re: [jira] Commented: (DERBY-66) Derby supports open cursor acrosscommits and hence DatabaseMetaData.supportsOpenCursorsAcrossCommit return true.

Based on the discussion we have had on this bug, I will submit a patch which will return
true for DatabaseMetaData.supportsOpenCursorsAcrossCommit.

thanks,
Mamta

Shreyas Kaushik wrote:

> Can someone please update what is happening on this issue?
>
> thanks
> Shreyas
>
> Shreyas Kaushik (JIRA) wrote:
> >      [ http://nagoya.apache.org/jira/browse/DERBY-66?page=comments#action_57008 ]
> >
> > Shreyas Kaushik commented on DERBY-66:
> > --------------------------------------
> >
> > I think it's the other way around. As the JDBC api says "Retrieves whether this database supports keeping cursors open across commits" it is the property of the database.
> >
> > Since Derby can have cursors that are open across commits it should return true.
> >
> > To be even precise, when creating a ResultSet handle that needs to have cursors open across commits, a check on whether the underlying Database supports such a holdability has to be checked.
> >
> >
> >>Derby supports open cursor across commits and hence DatabaseMetaData.supportsOpenCursorsAcrossCommit return true.
> >>-----------------------------------------------------------------------------------------------------------------
> >>
> >>         Key: DERBY-66
> >>         URL: http://nagoya.apache.org/jira/browse/DERBY-66
> >>     Project: Derby
> >>        Type: Bug
> >>  Components: JDBC
> >>    Versions: 10.0.2.0
> >>    Reporter: Mamta A. Satoor
> >>    Priority: Minor
> >
> >
> >>Derby returns false for DatabaseMetaData.supportsOpenCursorsAcrossCommit. But that seems incorrect because Derby does support open cursor across commits and hence DatabaseMetaData.supportsOpenCursorsAcrossCommit return true.
> >
> >


[PATCH] (DERBY-66) Derby does not support open cursor across commits for XA transactions and hence DatabaseMetaData.supportsOpenCursorsAcrossCommit should return false.

Posted by Mamta Satoor <ma...@Remulak.Net>.
Hi,

Can a commiter please commit the attached patch for Derby-66? The patch will have
DatabaseMetaData.supportsOpenCursorsAcrossCommit return false because Derby
does not support open cursors across commit for XA transactions. I have put a
comment in the code so we know why this method should return false.

thanks,
Mamta

[PATCH] (DERBY-66) Derby supports open cursor acrosscommits and hence DatabaseMetaData.supportsOpenCursorsAcrossCommit return true.

Posted by Mamta Satoor <ma...@Remulak.Net>.
If the attached patch looks good, can one of the commiters commit it?

Mamta Satoor wrote:

>
> Here is a simple patch for the bug. Please review, comment/vote on it.
>
> thanks,
> Mamta
>
> > > Shreyas Kaushik (JIRA) wrote:
> > > >      [ http://nagoya.apache.org/jira/browse/DERBY-66?page=comments#action_57008 ]
> > > >
> > > > Shreyas Kaushik commented on DERBY-66:
> > > > --------------------------------------
> > > >
> > > > I think it's the other way around. As the JDBC api says "Retrieves whether this database supports keeping cursors open across commits" it is the property of the database.
> > > >
> > > > Since Derby can have cursors that are open across commits it should return true.
> > > >
> > > > To be even precise, when creating a ResultSet handle that needs to have cursors open across commits, a check on whether the underlying Database supports such a holdability has to be checked.
> > > >
> > > >



Re: [jira] Commented: (DERBY-66) Derby supports open cursor acrosscommits and hence DatabaseMetaData.supportsOpenCursorsAcrossCommit return true.

Posted by Mamta Satoor <ma...@Remulak.Net>.

Mamta Satoor wrote:

> Based on the discussion we have had on this bug, I will submit a patch which will return
> true for DatabaseMetaData.supportsOpenCursorsAcrossCommit.
>
> thanks,
> Mamta
>
> Shreyas Kaushik wrote:
>
> > Can someone please update what is happening on this issue?
> >
> > thanks
> > Shreyas
> >
> > Shreyas Kaushik (JIRA) wrote:
> > >      [ http://nagoya.apache.org/jira/browse/DERBY-66?page=comments#action_57008 ]
> > >
> > > Shreyas Kaushik commented on DERBY-66:
> > > --------------------------------------
> > >
> > > I think it's the other way around. As the JDBC api says "Retrieves whether this database supports keeping cursors open across commits" it is the property of the database.
> > >
> > > Since Derby can have cursors that are open across commits it should return true.
> > >
> > > To be even precise, when creating a ResultSet handle that needs to have cursors open across commits, a check on whether the underlying Database supports such a holdability has to be checked.
> > >
> > >
> > >>Derby supports open cursor across commits and hence DatabaseMetaData.supportsOpenCursorsAcrossCommit return true.
> > >>-----------------------------------------------------------------------------------------------------------------
> > >>
> > >>         Key: DERBY-66
> > >>         URL: http://nagoya.apache.org/jira/browse/DERBY-66
> > >>     Project: Derby
> > >>        Type: Bug
> > >>  Components: JDBC
> > >>    Versions: 10.0.2.0
> > >>    Reporter: Mamta A. Satoor
> > >>    Priority: Minor
> > >
> > >
> > >>Derby returns false for DatabaseMetaData.supportsOpenCursorsAcrossCommit. But that seems incorrect because Derby does support open cursor across commits and hence DatabaseMetaData.supportsOpenCursorsAcrossCommit return true.
> > >
> > >

Here is a simple patch for the bug. Please review, comment/vote on it.

thanks,
Mamta