You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Manikandan R (JIRA)" <ji...@apache.org> on 2017/10/12 18:33:00 UTC
[jira] [Commented] (YARN-6953) Clean up
ResourceUtils.setMinimumAllocationForMandatoryResources() and
setMaximumAllocationForMandatoryResources()
[ https://issues.apache.org/jira/browse/YARN-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202415#comment-16202415 ]
Manikandan R commented on YARN-6953:
------------------------------------
Can we move ahead if patch is good?
> Clean up ResourceUtils.setMinimumAllocationForMandatoryResources() and setMaximumAllocationForMandatoryResources()
> ------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6953
> URL: https://issues.apache.org/jira/browse/YARN-6953
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Manikandan R
> Priority: Minor
> Labels: newbie
> Attachments: YARN-6953-YARN-3926-WIP.patch, YARN-6953-YARN-3926.001.patch, YARN-6953-YARN-3926.002.patch, YARN-6953-YARN-3926.003.patch, YARN-6953-YARN-3926.004.patch, YARN-6953-YARN-3926.005.patch, YARN-6953-YARN-3926.006.patch, YARN-6953.007.patch, YARN-6953.008.patch
>
>
> The {{setMinimumAllocationForMandatoryResources()}} and {{setMaximumAllocationForMandatoryResources()}} methods are quite convoluted. They'd be much simpler if they just handled CPU and memory manually instead of trying to be clever about doing it in a loop. There are also issues, such as the log warning always talking about memory or the last element of the inner array being a copy of the first element.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org