You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/05/13 21:27:25 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2094: Upgrade helix-front to Angular 9.1
micahstubbs opened a new pull request, #2094:
URL: https://github.com/apache/helix/pull/2094
### Issues
Fix #2092
### Description
This PR upgrades helix-front to Angular 9.1. This PR completely contains earlier helix-front upgrade PRs #2092, #2087, #2083, and #2078. These previous Angular major-version PRs should be merged first.
### Tests
Let's test the upgrade from Angular 8.2 to Angular 9.1.
- [x] `npm install` works
- [x] `npm rm type:check:watch` shows 0 TypeScript errors
- [x] `npm run lint` runs and passes `All files pass linting.`
- [x] `npm run build` works
- [x] `npm start` works, with 0 errors in the browser console.
- [x] `npm run test` runs and passes.
`npm start` works as expected, and recognizes our proxy config in `proxy.conf.json`.
<img width="697" alt="Screen Shot 2022-05-13 at 1 32 51 PM" src="https://user-images.githubusercontent.com/2119400/168385373-dfcf2eae-ef18-40e6-8af5-5dccaa6e532a.png">
Helix UI renders with 0 errors and 1 warning in the browser console. The warning is understandable since the piwik telemetry library is not configured.
`npm run test` results
<img width="742" alt="Screen Shot 2022-05-13 at 2 24 31 PM" src="https://user-images.githubusercontent.com/2119400/168391523-849c115a-b2ea-4d44-bd15-32680af480e6.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2094: Upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2094:
URL: https://github.com/apache/helix/pull/2094#issuecomment-1140510211
New PR with clean history: https://github.com/apache/helix/pull/2125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2094: Upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2094:
URL: https://github.com/apache/helix/pull/2094#issuecomment-1140509506
will close for bad merge earlier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs closed pull request #2094: Upgrade helix-front to Angular 9.1
Posted by GitBox <gi...@apache.org>.
micahstubbs closed pull request #2094: Upgrade helix-front to Angular 9.1
URL: https://github.com/apache/helix/pull/2094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org