You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/10 21:01:20 UTC
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request
#2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
sv2000 commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916#discussion_r390608708
##########
File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterUtils.java
##########
@@ -63,8 +68,9 @@ public static Path getAppWorkDirPath(FileSystem fs, String applicationName, Stri
public static Path getAppWorkDirPathFromConfig(Config config, FileSystem fs,
String applicationName, String applicationId) {
- if (config.hasPath(CLUSTER_WORK_DIR)) {
- return new Path(config.getString(CLUSTER_WORK_DIR));
+ if (config.hasPath(GobblinClusterConfigurationKeys.CLUSTER_WORK_DIR)) {
+ return new Path(new Path(fs.getUri()), PathUtils.combinePaths(config.getString(GobblinClusterConfigurationKeys.CLUSTER_WORK_DIR),
Review comment:
Added logs on the caller side instead of inside the utility method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services