[jira] [Commented] (PROTON-696) The header file usage needs some improvement

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145905#comment-14145905 ] 

ASF subversion and git services commented on PROTON-696:
--------------------------------------------------------

Commit 1627219 from [~astitcher] in branch 'proton/trunk'
[ https://svn.apache.org/r1627219 ]

PROTON-696: Rearrange the header files:
- Reduce transitive header inclusions
- Remove proton/util.h and move its contents to src/util.h. All
  the defined symbols were internal.
- Stop including with lines like #include "../blah.h" as this
  isn't needed anymore.
(Fixes windows breakage from PROTON-676)

> The header file usage needs some improvement
> --------------------------------------------
>
>                 Key: PROTON-696
>                 URL: https://issues.apache.org/jira/browse/PROTON-696
>             Project: Qpid Proton
>          Issue Type: Improvement
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>
> There are a number of small header file problems with proton.
> * Some header files include too many other header files and so export too many symbols - this is especially problematic if they use platform header files.
> * Conversely some header files are not self contained and do not define all the symbols they use (by using the correct include files themselves)
> * There are symbols exported in the installed header files which are internal only symbols



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)