You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2023/05/30 13:53:25 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7570: interpret /etc/redhet-release better
DaanHoogland opened a new pull request, #7570:
URL: https://github.com/apache/cloudstack/pull/7570
### Description
This PR fixes the way /etc/redhat-release is read to return host attributes
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
Fixes: #7547
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
tested on a host manually by editting the /etc/redhat-release file and verifying different outputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7570: interpret /etc/redhat-release better
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1584094367
@blueorangutan test rocky8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7570: interpret /etc/redhat-release better
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1568590775
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7570: interpret /etc/redhat-release better
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1637187504
@mlsorensen , Your method will certainly work, but I think we need to add an example query to the release notes for this explaining why it happens and how to fix it. I think we need to keep guaranteeing only one version of hosts in a cluster and if we want to add a new host we can not ignore the hosts OS and this method is not going to work. Do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7570: interpret /etc/redhat-release better
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1576934253
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7570: interpret /etc/redhat-release better
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1584096515
@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7570: interpret /etc/redhat-release better
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1582246208
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7570: interpret /etc/redhat-release better
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1584150938
looks good.
checked two rocky8 environment
- without this PR
```
mysql> select * from host_details where name not in ('username','password');
+----+---------+----------------------------------------------------+---------------------------+
| id | host_id | name | value |
+----+---------+----------------------------------------------------+---------------------------+
| 1 | 1 | Host.OS.Kernel.Version | 6.3.6-1.el8.elrepo.x86_64 |
| 2 | 1 | com.cloud.network.Networks.RouterPrivateIpStrategy | HostLocal |
| 3 | 1 | Host.OS.Version | 8.4 |
| 4 | 1 | host.volume.encryption | true |
| 5 | 1 | secured | true |
| 6 | 1 | Host.OS | Rocky |
| 15 | 2 | Host.OS.Kernel.Version | 6.3.6-1.el8.elrepo.x86_64 |
| 16 | 2 | com.cloud.network.Networks.RouterPrivateIpStrategy | HostLocal |
| 17 | 2 | Host.OS.Version | 8.4 |
| 18 | 2 | host.volume.encryption | true |
| 19 | 2 | secured | true |
| 20 | 2 | Host.OS | Rocky |
```
- with this PR
```
mysql> select * from host_details where name not in ('username','password');
+----+---------+----------------------------------------------------+---------------------------+
| id | host_id | name | value |
+----+---------+----------------------------------------------------+---------------------------+
| 1 | 1 | Host.OS.Kernel.Version | 6.3.6-1.el8.elrepo.x86_64 |
| 2 | 1 | com.cloud.network.Networks.RouterPrivateIpStrategy | HostLocal |
| 3 | 1 | Host.OS.Version | 8.4 |
| 4 | 1 | host.volume.encryption | true |
| 5 | 1 | secured | true |
| 6 | 1 | Host.OS | Rocky Linux |
| 15 | 2 | Host.OS.Kernel.Version | 6.3.6-1.el8.elrepo.x86_64 |
| 16 | 2 | com.cloud.network.Networks.RouterPrivateIpStrategy | HostLocal |
| 17 | 2 | Host.OS.Version | 8.4 |
| 18 | 2 | host.volume.encryption | true |
| 19 | 2 | secured | true |
| 20 | 2 | Host.OS | Rocky Linux |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7570: interpret /etc/redhat-release better
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1584087290
@weizhouapache [SF] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7570: interpret /etc/redhat-release better
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1568592064
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7570?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7570](https://app.codecov.io/gh/apache/cloudstack/pull/7570?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (704b8a2) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/17e765e6bc938fa1023599147d600733d2bb0403?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (17e765e) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.18 #7570 +/- ##
=========================================
Coverage 12.97% 12.97%
Complexity 8964 8964
=========================================
Files 2716 2716
Lines 256153 256153
Branches 39948 39948
=========================================
Hits 33226 33226
Misses 218767 218767
Partials 4160 4160
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7570: interpret /etc/redhat-release better
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1583554193
<b>[SF] Trillian test result (tid-6705)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45095 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7570-t6705-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 79.78 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 52.56 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7570: interpret /etc/redhet-release better
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1568481674
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7570: interpret /etc/redhet-release better
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1568478414
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mlsorensen commented on pull request #7570: interpret /etc/redhat-release better
Posted by "mlsorensen (via GitHub)" <gi...@apache.org>.
mlsorensen commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1635966365
FY @DaanHoogland @rohityadavcloud @weizhouapache I - this may break upgrades since the host OS details needs to match the rest of the cluster for agents to join. See #7742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7570: interpret /etc/redhat-release better
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1584086622
@blueorangutan test r8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7570: interpret /etc/redhat-release better
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7570: interpret /etc/redhat-release better
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1585151518
<b>[SF] Trillian test result (tid-6710)</b>
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49394 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7570-t6710-kvm-rocky8.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7570: interpret /etc/redhat-release better
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1582244850
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org