You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "tsreaper (via GitHub)" <gi...@apache.org> on 2024/07/11 09:35:30 UTC
[PR] [core] Introduce IcebergCommitCallback to create Iceberg metadata after commit [paimon]
tsreaper opened a new pull request, #3731:
URL: https://github.com/apache/paimon/pull/3731
### Purpose
Iceberg is a popular data lake format. In order to have more users try out Paimon while keeping their existing Iceberg workflow, we introduce `IcebergCommitCallback` in this PR to create Iceberg metadata after commit.
With this feature, Iceberg readers can read Paimon's `RawFile`s.
### Tests
* Unit tests
### API and Format
No changes in Paimon format.
### Documentation
Yes. Document will be added later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Introduce IcebergCommitCallback to create Iceberg metadata after commit [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #3731:
URL: https://github.com/apache/paimon/pull/3731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Introduce IcebergCommitCallback to create Iceberg metadata after commit [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3731:
URL: https://github.com/apache/paimon/pull/3731#discussion_r1673743009
##########
paimon-hive/paimon-hive-connector-common/src/main/java/org/apache/paimon/hive/SearchArgumentToPredicateConverter.java:
##########
@@ -145,23 +145,24 @@ private Predicate convertLeaf(PredicateLeaf leaf) {
DataType columnType = columnTypes.get(idx);
switch (leaf.getOperator()) {
case EQUALS:
- return builder.equal(idx, toLiteral(columnType, leaf.getLiteral()));
Review Comment:
Please create a sparate PR for this.
##########
paimon-hive/paimon-hive-connector-common/src/main/java/org/apache/paimon/hive/SearchArgumentToPredicateConverter.java:
##########
@@ -145,23 +145,24 @@ private Predicate convertLeaf(PredicateLeaf leaf) {
DataType columnType = columnTypes.get(idx);
switch (leaf.getOperator()) {
case EQUALS:
- return builder.equal(idx, toLiteral(columnType, leaf.getLiteral()));
Review Comment:
Please create a saparate PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Introduce IcebergCommitCallback to create Iceberg metadata after commit [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3731:
URL: https://github.com/apache/paimon/pull/3731#discussion_r1673743009
##########
paimon-hive/paimon-hive-connector-common/src/main/java/org/apache/paimon/hive/SearchArgumentToPredicateConverter.java:
##########
@@ -145,23 +145,24 @@ private Predicate convertLeaf(PredicateLeaf leaf) {
DataType columnType = columnTypes.get(idx);
switch (leaf.getOperator()) {
case EQUALS:
- return builder.equal(idx, toLiteral(columnType, leaf.getLiteral()));
Review Comment:
Please create a separate PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Introduce IcebergCommitCallback to create Iceberg metadata after commit [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3731:
URL: https://github.com/apache/paimon/pull/3731#discussion_r1675024583
##########
paimon-core/src/main/java/org/apache/paimon/iceberg/IcebergPathFactory.java:
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.iceberg;
+
+import org.apache.paimon.fs.Path;
+import org.apache.paimon.utils.PathFactory;
+
+import java.util.UUID;
+
+/** Path factory for Iceberg metadata files. */
+public class IcebergPathFactory {
+
+ private final Path root;
Review Comment:
just store `metadataDirectory`? to avoid exposing root to the entire class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org