You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/05/13 07:12:15 UTC
[GitHub] [mynewt-nimble] bvdberg opened a new pull request, #1257: nimble/ll: only let ble_ll.c add/remove to ll_evq
bvdberg opened a new pull request, #1257:
URL: https://github.com/apache/mynewt-nimble/pull/1257
- change all ble_npl_eventq_put(&g_ble_ll_data.ll_evq, ..) -> ble_ll_event_add(..)
- change all ble_npl_eventq_remove(&g_ble_ll_data.ll_evq, ..) -> ble_ll_event_remove(..)
- rename ble_ll_event_send -> ble_ll_event_add (matches more with remove)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] bvdberg commented on pull request #1257: nimble/ll: only let ble_ll.c add/remove to ll_evq
Posted by GitBox <gi...@apache.org>.
bvdberg commented on PR #1257:
URL: https://github.com/apache/mynewt-nimble/pull/1257#issuecomment-1127268572
The patch didn't change most of those lines, so why does the Style check fail now? Is there a tool I can use the automatically set the style? (like astyle / clang-format?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] utzig commented on pull request #1257: nimble/ll: only let ble_ll.c add/remove to ll_evq
Posted by GitBox <gi...@apache.org>.
utzig commented on PR #1257:
URL: https://github.com/apache/mynewt-nimble/pull/1257#issuecomment-1126225540
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/controller/src/ble_ll_dtm.c
<details>
```diff
@@ -197,7 +196,8 @@
static int ble_ll_dtm_rx_start(void);
static void
-ble_ll_dtm_ev_rx_restart_cb(struct ble_npl_event *evt) {
+ble_ll_dtm_ev_rx_restart_cb(struct ble_npl_event *evt)
+{
if (ble_ll_dtm_rx_start() != 0) {
ble_ll_event_add(&g_ble_ll_dtm_ctx.evt);
STATS_INC(ble_ll_dtm_stats, rx_failed);
```
</details>
#### nimble/controller/src/ble_ll_sched.c
<details>
```diff
@@ -142,36 +142,36 @@
switch (entry->sched_type) {
#if MYNEWT_VAL(BLE_LL_ROLE_CENTRAL) || MYNEWT_VAL(BLE_LL_ROLE_PERIPHERAL)
- case BLE_LL_SCHED_TYPE_CONN:
- connsm = (struct ble_ll_conn_sm *)entry->cb_arg;
- ble_ll_event_add(&connsm->conn_ev_end);
- break;
+ case BLE_LL_SCHED_TYPE_CONN:
+ connsm = (struct ble_ll_conn_sm *)entry->cb_arg;
+ ble_ll_event_add(&connsm->conn_ev_end);
+ break;
#endif
#if MYNEWT_VAL(BLE_LL_ROLE_BROADCASTER)
- case BLE_LL_SCHED_TYPE_ADV:
- ble_ll_adv_event_rmvd_from_sched(entry->cb_arg);
- break;
+ case BLE_LL_SCHED_TYPE_ADV:
+ ble_ll_adv_event_rmvd_from_sched(entry->cb_arg);
+ break;
#endif
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV) && MYNEWT_VAL(BLE_LL_ROLE_OBSERVER)
- case BLE_LL_SCHED_TYPE_SCAN_AUX:
- ble_ll_scan_aux_break(entry->cb_arg);
- break;
+ case BLE_LL_SCHED_TYPE_SCAN_AUX:
+ ble_ll_scan_aux_break(entry->cb_arg);
+ break;
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_PERIODIC_ADV)
#if MYNEWT_VAL(BLE_LL_ROLE_BROADCASTER)
- case BLE_LL_SCHED_TYPE_PERIODIC:
- ble_ll_adv_periodic_rmvd_from_sched(entry->cb_arg);
- break;
+ case BLE_LL_SCHED_TYPE_PERIODIC:
+ ble_ll_adv_periodic_rmvd_from_sched(entry->cb_arg);
+ break;
#endif
#if MYNEWT_VAL(BLE_LL_ROLE_OBSERVER)
- case BLE_LL_SCHED_TYPE_SYNC:
- ble_ll_sync_rmvd_from_sched(entry->cb_arg);
- break;
-#endif
-#endif
-#endif
- default:
- BLE_LL_ASSERT(0);
- break;
+ case BLE_LL_SCHED_TYPE_SYNC:
+ ble_ll_sync_rmvd_from_sched(entry->cb_arg);
+ break;
+#endif
+#endif
+#endif
+ default:
+ BLE_LL_ASSERT(0);
+ break;
}
entry = next;
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #1257: nimble/ll: only let ble_ll.c add/remove to ll_evq
Posted by GitBox <gi...@apache.org>.
sjanc merged PR #1257:
URL: https://github.com/apache/mynewt-nimble/pull/1257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1257: nimble/ll: only let ble_ll.c add/remove to ll_evq
Posted by GitBox <gi...@apache.org>.
sjanc commented on PR #1257:
URL: https://github.com/apache/mynewt-nimble/pull/1257#issuecomment-1127427137
we need to tune it a bit better, this is informative (ie it doesn't block merge) so you may ignore those for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org