You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/10/23 09:06:00 UTC
[GitHub] [zeppelin] jenil-shah135 opened a new pull request #3953: [ZEPPELIN-5105] Add an option to allow S3 path based access
jenil-shah135 opened a new pull request #3953:
URL: https://github.com/apache/zeppelin/pull/3953
### What is this PR for?
Provide a configuration option that will allow to use path based access for S3 Notebook repo
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5105
### How should this be tested?
Start minio cluster without MINIO_DOMAIN. Configure minio s3 endpoint in zeppelin for notebook repo.Enable the configuration option, save a notebook in zeppelin, and confirm in the minio that the related file was saved.
### Questions:
Does the licenses files need update?
No
Is there breaking changes for older versions?
No.
Does this needs documentation?
I added mentions of the new option in existing documentation.
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jenil-shah135 commented on a change in pull request #3953: [ZEPPELIN-5105] Add an option to allow S3 path based access
Posted by GitBox <gi...@apache.org>.
jenil-shah135 commented on a change in pull request #3953:
URL: https://github.com/apache/zeppelin/pull/3953#discussion_r513902844
##########
File path: zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts
##########
@@ -118,6 +118,7 @@ export interface ConfigurationsInfo {
'zeppelin.notebook.collaborative.mode.enable': string;
'zeppelin.search.use.disk': string;
'zeppelin.notebook.s3.cannedAcl': string;
+ 'zeppelin.notebook.s3.pathStyleAccess': string;
Review comment:
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jenil-shah135 commented on a change in pull request #3953: [ZEPPELIN-5105] Add an option to allow S3 path based access
Posted by GitBox <gi...@apache.org>.
jenil-shah135 commented on a change in pull request #3953:
URL: https://github.com/apache/zeppelin/pull/3953#discussion_r513195146
##########
File path: zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts
##########
@@ -118,6 +118,7 @@ export interface ConfigurationsInfo {
'zeppelin.notebook.collaborative.mode.enable': string;
'zeppelin.search.use.disk': string;
'zeppelin.notebook.s3.cannedAcl': string;
+ 'zeppelin.notebook.s3.pathStyleAccess': string;
Review comment:
https://travis-ci.org/github/jenil-shah135/zeppelin/builds/739240932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3953: [ZEPPELIN-5105] Add an option to allow S3 path based access
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3953:
URL: https://github.com/apache/zeppelin/pull/3953#discussion_r511485235
##########
File path: zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts
##########
@@ -118,6 +118,7 @@ export interface ConfigurationsInfo {
'zeppelin.notebook.collaborative.mode.enable': string;
'zeppelin.search.use.disk': string;
'zeppelin.notebook.s3.cannedAcl': string;
+ 'zeppelin.notebook.s3.pathStyleAccess': string;
Review comment:
Is same change needs to be done in the old zeppelin ui module (zeppelin-web) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jenil-shah135 commented on a change in pull request #3953: [ZEPPELIN-5105] Add an option to allow S3 path based access
Posted by GitBox <gi...@apache.org>.
jenil-shah135 commented on a change in pull request #3953:
URL: https://github.com/apache/zeppelin/pull/3953#discussion_r511540643
##########
File path: zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts
##########
@@ -118,6 +118,7 @@ export interface ConfigurationsInfo {
'zeppelin.notebook.collaborative.mode.enable': string;
'zeppelin.search.use.disk': string;
'zeppelin.notebook.s3.cannedAcl': string;
+ 'zeppelin.notebook.s3.pathStyleAccess': string;
Review comment:
I don't think so any changes for old ui is required as it is using rest service to get all configuration keys which is using ZeppelinConfiguration. In that file I have already made required changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3953: [ZEPPELIN-5105] Add an option to allow S3 path based access
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3953:
URL: https://github.com/apache/zeppelin/pull/3953#discussion_r513876632
##########
File path: zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts
##########
@@ -118,6 +118,7 @@ export interface ConfigurationsInfo {
'zeppelin.notebook.collaborative.mode.enable': string;
'zeppelin.search.use.disk': string;
'zeppelin.notebook.s3.cannedAcl': string;
+ 'zeppelin.notebook.s3.pathStyleAccess': string;
Review comment:
> https://travis-ci.org/github/jenil-shah135/zeppelin/builds/739240932
Thanks, will merge it if no more comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3953: [ZEPPELIN-5105] Add an option to allow S3 path based access
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3953:
URL: https://github.com/apache/zeppelin/pull/3953#discussion_r511997217
##########
File path: zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts
##########
@@ -118,6 +118,7 @@ export interface ConfigurationsInfo {
'zeppelin.notebook.collaborative.mode.enable': string;
'zeppelin.search.use.disk': string;
'zeppelin.notebook.s3.cannedAcl': string;
+ 'zeppelin.notebook.s3.pathStyleAccess': string;
Review comment:
Thanks for clarify, Could you paste the travis CI link ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org