You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/09/23 13:44:36 UTC
[GitHub] [knox] smolnar82 opened a new pull request #501: KNOX-22670 - Deleting unnecessary removeToken override from AliasBasedTokenStateService
smolnar82 opened a new pull request #501:
URL: https://github.com/apache/knox/pull/501
## What changes were proposed in this pull request?
See the root cause analysis in https://issues.apache.org/jira/browse/KNOX-2670.
Additional note: the newly implemented `triesToRevokeOwnToken(String, String)` method solves the original issue 1 layer above, but the problem with the `AliasBasedTokenStateService` would still exist w/o removing the `removeToken(String)` method.
## How was this patch tested?
I ran Junit tests and I executed the steps I used for reproducing the original issue (I temporary removed the `triesToRevokeOwnToken(String, String)` call to make sure my change actually solves the issue).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #501: KNOX-2670 - Deleting unnecessary removeToken override from AliasBasedTokenStateService
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #501:
URL: https://github.com/apache/knox/pull/501#issuecomment-926025997
> LGTM. The patch looks good to me, but the inheritance hierarchy is a bit difficult to follow.
It's not that complicated IMO.
<img width="839" alt="Screenshot 2021-09-23 at 19 46 31" src="https://user-images.githubusercontent.com/34065904/134557895-24439797-f9a2-4e65-9482-e82d15daec22.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] zeroflag commented on pull request #501: KNOX-22670 - Deleting unnecessary removeToken override from AliasBasedTokenStateService
Posted by GitBox <gi...@apache.org>.
zeroflag commented on pull request #501:
URL: https://github.com/apache/knox/pull/501#issuecomment-925863289
LGTM. The patch looks good to me, but the inheritance hierarchy is a bit difficult to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #501: KNOX-22670 - Deleting unnecessary removeToken override from AliasBasedTokenStateService
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #501:
URL: https://github.com/apache/knox/pull/501#issuecomment-925830174
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #501: KNOX-2670 - Deleting unnecessary removeToken override from AliasBasedTokenStateService
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #501:
URL: https://github.com/apache/knox/pull/501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org