You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "vttranlina (via GitHub)" <gi...@apache.org> on 2023/07/17 11:09:23 UTC
[GitHub] [james-project] vttranlina opened a new pull request, #1647: Upgrade dependencies
vttranlina opened a new pull request, #1647:
URL: https://github.com/apache/james-project/pull/1647
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1647: Upgrade dependencies
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1658015908
I'm closing this, as this PR has been cut into smaller steps and some of those have been merged already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639258083
> Can you share the error?
sorry it did not throw, the query at `org.apache.james.backends.opensearch.OpenSearchIndexerTest#updateMessages` line 109 does not return totalHit = 1 (it returns 0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1647: Upgrade dependencies
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639288871
Agree.
Ticket please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1637916346
`io.cucumber` look very outdated, (from 2018)
the compile failed when I tried to update 2.4.0 -> 7.13.0, I'm not in it, so I keep 2.4.0
Maybe we should have a plan to update it or maybe drop it? (it only use in test classes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1643037724
Ci error
```
Not same digest as expected: expected <16073f10204751cd71d3b4ea93be2649> was <d41d8cd98f00b204e9800998ecf8427e> -> [Help 1]
```
I don't know why it does not match,
my md5 is `16073f10204751cd71d3b4ea93be2649`
<img width="551" alt="image" src="https://github.com/apache/james-project/assets/81145350/560d40a2-53e3-47c9-9df5-5b07e9eb9139">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a diff in pull request #1647: Upgrade dependencies
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1267624673
##########
server/apps/distributed-app/docker-compose.yml:
##########
@@ -44,7 +44,7 @@ services:
- "15672:15672"
s3:
- image: zenko/cloudserver:8.2.6
+ image: zenko/cloudserver:latest-7.10.19
Review Comment:
Means they migrated to their own repo. As long as it's public, there is no issue switching to it IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1647: Upgrade dependencies
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1265470858
##########
pom.xml:
##########
@@ -2496,15 +2497,20 @@
<artifactId>jaxb-api</artifactId>
<version>${jaxb.version}</version>
</dependency>
+ <dependency>
+ <groupId>net.javacrumbs.json-unit</groupId>
+ <artifactId>json-unit</artifactId>
+ <version>>${javacrumbs.json-unit.version}</version>
Review Comment:
Typo `>>` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1647: Upgrade dependencies
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639133719
org.apache.james.webadmin.routes.VacationRoutesTest.postVacationUpdatesAll
Minor date formating changes
```
expected: Optional[2021-09-20T10:00Z[UTC]]
but was: Optional[2021-09-20T10:00Z]
```
Is there a way to configure jackson to keep the timezone?
org.apache.james.backends.opensearch.OpenSearchIndexerTest.updateMessages
```
org.awaitility.core.ConditionTimeoutException:
Assertion condition defined as a lambda expression in org.apache.james.backends.opensearch.OpenSearchIndexerTest
expected: 1L
but was: 0L within 10 seconds.
at org.apache.james.backends.opensearch.OpenSearchIndexerTest.awaitForOpenSearch(OpenSearchIndexerTest.java:252)
at org.apache.james.backends.opensearch.OpenSearchIndexerTest.updateMessages(OpenSearchIndexerTest.java:109)
Caused by: org.opentest4j.AssertionFailedError:
expected: 1L
but was: 0L
at org.apache.james.backends.opensearch.OpenSearchIndexerTest.lambda$awaitForOpenSearch$9(OpenSearchIndexerTest.java:257)
```
Related?
org.apache.james.jmap.draft.crypto.SecurityKeyLoaderTest.loadShouldReturnAsymmetricKeysWhenRawPublicKey
```
The provided [org.bouncycastle.asn1.x509.SubjectPublicKeyInfo] pem type is not (yet) supported
```
Some bouncy castle magic required here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1647: Upgrade dependencies
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639609617
Ok yes there is still the `Z` which means zone offset. Of for the.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1643050188
> The digest is not stable, I encountered that as well.
it looks like from `download-maven-plugin` when upgrade 1.6.8 -> 1.7.0, I reverted it and now waiting to check new ci state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1647: Upgrade dependencies
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639294309
A;right give me a minute to create it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a diff in pull request #1647: Upgrade dependencies
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1267462472
##########
server/apps/distributed-app/docker-compose.yml:
##########
@@ -44,7 +44,7 @@ services:
- "15672:15672"
s3:
- image: zenko/cloudserver:8.2.6
+ image: zenko/cloudserver:latest-7.10.19
Review Comment:
Hm are you sure about this one? we go from 8.2.6 to 7.10.19... Can you double check? It could be fixes on the v7 and we would just go one version back actually
##########
backends-common/opensearch/pom.xml:
##########
@@ -88,7 +88,7 @@
<dependency>
<groupId>org.opensearch.client</groupId>
<artifactId>opensearch-rest-client</artifactId>
- <version>2.4.0</version>
+ <version>2.8.0</version>
Review Comment:
You forgot to revert this one too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1267464118
##########
backends-common/opensearch/pom.xml:
##########
@@ -88,7 +88,7 @@
<dependency>
<groupId>org.opensearch.client</groupId>
<artifactId>opensearch-rest-client</artifactId>
- <version>2.4.0</version>
+ <version>2.8.0</version>
Review Comment:
the test cases still pass with only upgrade opensearch-rest-client, so I still keep it
Do you think we should do both opensearch-rest-client, opensearch-java same time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1647: Upgrade dependencies
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1649427747
If there is still issues with this PR and you can't seem to get a green build, I would suggest to potentially break down this PR in smaller ones to make it easier to merge (as this is becoming a bit of a monster), like for example:
- lib updates
- maven plugins updates
- docker image updates
- etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1647: Upgrade dependencies
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639265446
Ok create a separate ticket to upgrade OpenSearch please...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1647: Upgrade dependencies
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639286447
OpenSearch you might want to upgrade the docker container as well, maybe the API slightly changed?
I agree to open a ticket just for this though. I just checked on Opensearch doc : https://opensearch.org/docs/latest/clients/java/
It seems the latest java client update has an integrated transport class. We need to measure the impact of refactoring that would allow us to drop the rest client library. If it's not too bad, then we need perf tests as well to see if there is a gain or not. If the result is good enough, we could switch and drop the opensearch-rest-client dependency.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a diff in pull request #1647: Upgrade dependencies
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1267623925
##########
backends-common/opensearch/pom.xml:
##########
@@ -88,7 +88,7 @@
<dependency>
<groupId>org.opensearch.client</groupId>
<artifactId>opensearch-rest-client</artifactId>
- <version>2.4.0</version>
+ <version>2.8.0</version>
Review Comment:
Ok for keeping it.
No the goal of upgrading opensearch-java is that it might allow us to drop opensearch-rest-client dependency for good :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1647: Upgrade dependencies
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639192006
Can you share the error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1647: Upgrade dependencies
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1643045089
The digest is not stable, I encountered that as well.
-> Open a ticket upstream on glowroot github?
-> We might temporarilly drop glowroot, like we did on 3.7.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1643785729
Squash fixup & rebase master & add new commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1647: Upgrade dependencies
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1645225286
Hm indeed... Maybe something wrong with the VM docker or connection issue when trying to fetch the image?Let me restart your build and we will see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael closed pull request #1647: Upgrade dependencies
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael closed pull request #1647: Upgrade dependencies
URL: https://github.com/apache/james-project/pull/1647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1269355902
##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -133,7 +133,7 @@ private static String buildSpecificImageDiscriminator() {
@SuppressWarnings("resource")
public DockerCassandra() {
- this("cassandra_3_11_10-" + buildSpecificImageDiscriminator(), AdditionalDockerFileStep.IDENTITY);
+ this("cassandra_3_11_15-" + buildSpecificImageDiscriminator(), AdditionalDockerFileStep.IDENTITY);
Review Comment:
https://github.com/linagora/james-project/issues/4822
##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -133,7 +133,7 @@ private static String buildSpecificImageDiscriminator() {
@SuppressWarnings("resource")
public DockerCassandra() {
- this("cassandra_3_11_10-" + buildSpecificImageDiscriminator(), AdditionalDockerFileStep.IDENTITY);
+ this("cassandra_3_11_15-" + buildSpecificImageDiscriminator(), AdditionalDockerFileStep.IDENTITY);
Review Comment:
Ticket: https://github.com/linagora/james-project/issues/4822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1267499846
##########
server/apps/distributed-app/docker-compose.yml:
##########
@@ -44,7 +44,7 @@ services:
- "15672:15672"
s3:
- image: zenko/cloudserver:8.2.6
+ image: zenko/cloudserver:latest-7.10.19
Review Comment:
you are right,
them hasn't stored all images on dockerhub
It should be `registry.scality.com/cloudserver/cloudserver:8.7.25`
tldr: https://github.com/scality/cloudserver/issues/4986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1647: Upgrade dependencies
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1265465668
##########
pom.xml:
##########
@@ -2294,7 +2295,7 @@
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.11.0</version>
+ <version>2.13.0</version>
Review Comment:
Does commons-io bring UnsynchronizedBuffered Input/Output Streams?
If so we might take advantage of this to drop the corresponding James classes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639180718
> org.apache.james.backends.opensearch.OpenSearchIndexerTest.updateMessages
IMO we should keep opensearch-java 2.1.0 for easier, I don't know why 2.6.0 throw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1647: Upgrade dependencies
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1267960394
##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -133,7 +133,7 @@ private static String buildSpecificImageDiscriminator() {
@SuppressWarnings("resource")
public DockerCassandra() {
- this("cassandra_3_11_10-" + buildSpecificImageDiscriminator(), AdditionalDockerFileStep.IDENTITY);
+ this("cassandra_3_11_15-" + buildSpecificImageDiscriminator(), AdditionalDockerFileStep.IDENTITY);
Review Comment:
Why not switch to Cassandra 4.1.x (in another PR maybe?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1645215028
Ci Issue?
```
com.github.dockerjava.api.exception.NotFoundException: Status 404: {"message":"No such image: rabbitmq:3.12.1-management"}
```
The image is already available:: https://hub.docker.com/layers/library/rabbitmq/3.12.1-management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on pull request #1647: Upgrade dependencies
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1657783693
rebase needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1647:
URL: https://github.com/apache/james-project/pull/1647#issuecomment-1639405052
> org.apache.james.webadmin.routes.VacationRoutesTest.postVacationUpdatesAll
>
> Minor date formating changes
>
> ```
> expected: Optional[2021-09-20T10:00Z[UTC]]
> but was: Optional[2021-09-20T10:00Z]
> ```
>
> Is there a way to configure jackson to keep the timezone?
>
It looks like the new result after the update is better
This was intended since 2.15 https://github.com/FasterXML/jackson-modules-java8/pull/267
I think we should modify test cases for that (don't change the configuration ObjectMapper)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1647: Upgrade dependencies
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on code in PR #1647:
URL: https://github.com/apache/james-project/pull/1647#discussion_r1266416497
##########
pom.xml:
##########
@@ -2294,7 +2295,7 @@
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.11.0</version>
+ <version>2.13.0</version>
Review Comment:
> Does commons-io bring UnsynchronizedBuffered Input/Output Streams?
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org