You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/07 00:10:34 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request, #17496: [improve][broker] Improve `retention` endpoint to pure async.
mattisonchao opened a new pull request, #17496:
URL: https://github.com/apache/pulsar/pull/17496
### Motivation
Since Pulsar is a fully asynchronous project, we need to avoid using thread-blocking methods.
Also, we can see https://github.com/apache/pulsar/issues/14365
### Modifications
- Improve backlogQuota relative endpoint to pure async.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #17496: [improve][broker] Improve `retention` endpoint to pure async.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #17496: [improve][broker] Improve `retention` endpoint to pure async.
URL: https://github.com/apache/pulsar/pull/17496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #17496: [improve][broker] Improve `retention` endpoint to pure async.
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #17496:
URL: https://github.com/apache/pulsar/pull/17496#discussion_r975160499
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -1307,33 +1307,30 @@ protected void internalRemoveBacklogQuota(BacklogQuotaType backlogQuotaType) {
}
}
- protected void internalSetRetention(RetentionPolicies retention) {
- validateRetentionPolicies(retention);
- validateNamespacePolicyOperation(namespaceName, PolicyName.RETENTION, PolicyOperation.WRITE);
- validatePoliciesReadOnlyAccess();
-
+ protected CompletableFuture<Void> internalSetRetentionAsync(RetentionPolicies retentionPolicies) {
try {
- Policies policies = namespaceResources().getPolicies(namespaceName)
- .orElseThrow(() -> new RestException(Status.NOT_FOUND,
- "Namespace policies does not exist"));
- if (!checkQuotas(policies, retention)) {
Review Comment:
Maybe we can delete this method.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java:
##########
@@ -1195,12 +1195,16 @@ public void getRetention(@Suspended final AsyncResponse asyncResponse,
@PathParam("namespace") String namespace) {
validateNamespaceName(property, cluster, namespace);
validateNamespacePolicyOperationAsync(namespaceName, PolicyName.RETENTION, PolicyOperation.READ)
- .thenCompose(__ -> getNamespacePoliciesAsync(namespaceName))
- .thenAccept(policies -> asyncResponse.resume(policies.retention_policies))
Review Comment:
Why need to change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org