Re: [PR] Fix incorrect handling of missing values in ToParentBlockJoinSortField (#15548) [lucene]

["gmarouli (via GitHub)" <gi...@apache.org>]

gmarouli commented on PR #15727:
URL: https://github.com/apache/lucene/pull/15727#issuecomment-3986557368

   > Nearly there, I think! Sorry this is taking so long...
   
   No problem at all, thank you for spending taking this time. 
   
   I misunderstood how the ordinal was used, your suggestion made me take another look with fresh eyes :). I followed the same approach as in `NumDV ` and this simplified things a lot,  `TestBlockJoinSelector.testSortedSelector()`  looks much cleaner too.
   
   Thank you so much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org