[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2483: [Feature][File connector] Support ftp file sink

[GitBox <gi...@apache.org>]

TyrantLucifer commented on code in PR #2483:
URL: https://github.com/apache/incubator-seatunnel/pull/2483#discussion_r950811223


##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/FileSinkWriterWithTransaction.java:
##########
@@ -50,7 +50,7 @@ public class FileSinkWriterWithTransaction implements SinkWriter<SeaTunnelRow, F
 

Review Comment:
   Please keep this file change out of your submission, give you a advice, you can revert this file and keep this file the same as dev branch.



##########
seatunnel-connectors-v2/connector-file/connector-file-ftp/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/ftp/config/Config.java:
##########
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 package org.apache.seatunnel.connectors.seatunnel.file.sink.ftp.config;
 
 public class Config {

Review Comment:
   Change this class name from `Config` to `FtpConfig` is best.



##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/split/FileSourceSplitEnumerator.java:
##########
@@ -37,12 +37,12 @@ public class FileSourceSplitEnumerator implements SourceSplitEnumerator<FileSour
     private Set<FileSourceSplit> assignedSplit;

Review Comment:
   Please keep this file change out of your submission, give you a advice, you can revert this file and keep this file the same as dev branch.



##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/TransactionStateFileSinkWriter.java:
##########
@@ -50,7 +50,7 @@ public class TransactionStateFileSinkWriter implements SinkWriter<SeaTunnelRow,
 

Review Comment:
   Please keep this file change out of your submission, give you a advice, you can revert this file and keep this file the same as dev branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org