You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/07/01 18:09:43 UTC
[GitHub] [druid] gianm commented on pull request #12717: Add EIGHT_HOUR into possible list of Granularities.
gianm commented on PR #12717:
URL: https://github.com/apache/druid/pull/12717#issuecomment-1172595957
There is one reason we do need to add new explicit granularities. Currently, allocation logic (for streaming ingest tasks, and batch tasks in append mode) can only work properly with segments that are predefined granularities. The reason is they use `Granularity.granularitiesFinerThan` which references `GranularityType.values()`. If we can fix that, then this patch isn't necessary. But if we can't fix that, then this patch is still useful.
Anyone got some time to look into the allocation thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org