You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by arminwasicek <gi...@git.apache.org> on 2018/06/01 21:27:22 UTC

[GitHub] zeppelin pull request #3001: [ZEPPELIN-3524] Replace the Amazon json libs wi...

GitHub user arminwasicek opened a pull request:

    https://github.com/apache/zeppelin/pull/3001

    [ZEPPELIN-3524] Replace the Amazon json libs with org.json

    ### What is this PR for?
    Currently, Zeppelin uses a JSON library that Amazon deprecated in subsequent releases. This PR replaces Amazon's wrapped library with the original from org.json.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Testing
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3524
    
    ### How should this be tested?
    Compiles locally, no unit test performed.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    No, license is "The Software shall be used for Good, not Evil."
    
    * Is there breaking changes for older versions?
    This should be backward compatible
    
    * Does this needs documentation?
    Nope, this is just replacing a wrapped library with its original.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arminwasicek/zeppelin replace-aws-json-lib-with-org.json

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3001.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3001
    
----
commit 7f925704c8f2b261994dba516b7bacb88c246553
Author: Armin Wasicek <ar...@...>
Date:   2018-06-01T21:19:58Z

    Replace the Amazon json libs with org.json

----


---

[GitHub] zeppelin issue #3001: [ZEPPELIN-3524] Replace the Amazon json libs with org....

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3001
  
    @arminwasicek ping


---

[GitHub] zeppelin issue #3001: [ZEPPELIN-3524] Replace the Amazon json libs with org....

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3001
  
    BTW, this module already has `gson` as a dependency. Do you have any reason adding it?


---

[GitHub] zeppelin issue #3001: [ZEPPELIN-3524] Replace the Amazon json libs with org....

Posted by arminwasicek <gi...@git.apache.org>.

Github user arminwasicek commented on the issue:

    https://github.com/apache/zeppelin/pull/3001
  
    The story is that Amazon deprecated their use of json.org and moved to jackson. The Zeppelin code in question uses on json.org through the import of the Amazon lib. The change I'm proposing is to explicitly include json.org, so everything else can stay the same. 
    
    Using gson (or jackson via amazon for that matter) would make sense, but this entails changing more code.
    



---

[GitHub] zeppelin issue #3001: [ZEPPELIN-3524] Replace the Amazon json libs with org....

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3001
  
    Sorry for the late reply. As you mentioned, Zeppelin already has two or more json dependencies at the same time, but I don't think it's good and we can fix it when we can do and have a chance. How about fixing it in this time?


---