You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kaka1992 <gi...@git.apache.org> on 2015/04/29 04:53:42 UTC
[GitHub] spark pull request: [SPARK-7194][MLLIB] Vectors factors method for...
GitHub user kaka1992 opened a pull request:
https://github.com/apache/spark/pull/5766
[SPARK-7194][MLLIB] Vectors factors method for sparse vectors should accept the output of zipWithIndex
Add a new Vectors.sparse(arr: Array[Double])
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaka1992/spark add_new_sparse
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5766.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5766
----
commit 6634ee9b333b18c061367c3e6095dcddb238b3a8
Author: 云峤 <ch...@alibaba-inc.com>
Date: 2015-04-29T02:51:18Z
SPARK-7149 add a new sparser
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7194][MLLIB] Vectors factors method for...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5766#issuecomment-97498558
@kaka1992 this wasn't quite the proposal in the JIRA anyway; it had to do with accepting either order of tuple.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7194][MLLIB] Vectors factors method for...
Posted by kaka1992 <gi...@git.apache.org>.
Github user kaka1992 commented on the pull request:
https://github.com/apache/spark/pull/5766#issuecomment-97295794
Ok, I'll close this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7194][MLLIB] Vectors factors method for...
Posted by kaka1992 <gi...@git.apache.org>.
Github user kaka1992 closed the pull request at:
https://github.com/apache/spark/pull/5766
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7194][MLLIB] Vectors factors method for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5766#issuecomment-97290185
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7194][MLLIB] Vectors factors method for...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5766#issuecomment-97295078
See #5756. Users should be able to write `Vectors.dense(1.0, 0.0, 3.0).toSparse`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7194][MLLIB] Vectors factors method for...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5766#issuecomment-97290892
@kaka1992 I don't see why this is useful. Creating a dense vector directly is certainly more efficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7194][MLLIB] Vectors factors method for...
Posted by kaka1992 <gi...@git.apache.org>.
Github user kaka1992 commented on the pull request:
https://github.com/apache/spark/pull/5766#issuecomment-97294042
@mengxr Just provide a way to turn DeseV to SparseV easily. Somebody may need this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org