You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/09 03:53:07 UTC
[GitHub] [incubator-superset] junlincc opened a new issue #11968: [explore]not required to fetch samples data when...
junlincc opened a new issue #11968:
URL: https://github.com/apache/incubator-superset/issues/11968
Context -
I noticed that on current master, we send a request for samples not only when chart data changes, but every time we open a modal.
I think that the "View Samples" use case is fairly uncommon. Also note that it only needs to be reprocess when the filters are altered, changing metrics and other query parameters don't require re-fetching/re-rendering.
_Originally posted by @mistercrunch in https://github.com/apache/incubator-superset/issues/11854#issuecomment-738606061_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #11968: [explore]only fetch View Samples data when needed
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #11968:
URL: https://github.com/apache/incubator-superset/issues/11968#issuecomment-748003416
> The rendering performance is also not very great while the "View Samples" tab is open. Sorting that table and resizing the panes are almost unbearably slow. Even adding/removing a metric also becomes slow.
Oh that's what that was. I hit this yesterday and wondered why everything became so sluggish all of a sudden.
> @ktmud Shall we open an issue for performance improvements?
Yeah, I think this is pretty important to fix, as the new layout will probably result in increased use of the Samples tab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11968: [explore]only fetch View Samples data when needed
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11968:
URL: https://github.com/apache/incubator-superset/issues/11968#issuecomment-748001961
@ktmud Shall we open an issue for performance improvements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #11968: [explore]only fetch View Samples data when needed
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #11968:
URL: https://github.com/apache/incubator-superset/issues/11968#issuecomment-747945240
The rendering performance is also not very great while the "View Samples" tab is open. Sorting that table and resizing the panes are almost unberable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #11968: [explore]only fetch View Samples data when needed
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #11968:
URL: https://github.com/apache/incubator-superset/issues/11968#issuecomment-747946368
And it stays slow even when I switched back to the View Results tab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on issue #11968: [explore]only fetch View Samples data when needed
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #11968:
URL: https://github.com/apache/incubator-superset/issues/11968#issuecomment-747945240
The rendering performance is also not very great while the "View Samples" tab is open. Sorting that table and resizing the panes are almost unbearably slow. Even adding/removing a metric also becomes slow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org