You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/04/06 20:28:30 UTC

[GitHub] [buildstream] nanonyme commented on a diff in pull request #1632: tests: xfail integration tests that fail without buildbox-fuse

nanonyme commented on code in PR #1632:
URL: https://github.com/apache/buildstream/pull/1632#discussion_r844393057


##########
tests/integration/script.py:
##########
@@ -171,6 +172,7 @@ def test_script_layout(cli, datafiles):
     HAVE_SANDBOX == "buildbox-run" and BUILDBOX_RUN == "buildbox-run-userchroot",
     reason="Root directory not writable with userchroot",
 )
+@pytest.mark.xfail(not HAVE_BUILDBOX_FUSE, reason="Root directory not writable without buildbox-fuse")

Review Comment:
   Does it really make sense to xfail rather scenarios that cannot possibly work? Doesn't it just make everything slower?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org