You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/08 02:54:11 UTC
[jira] [Commented] (BEAM-431) Examples dependencies on runners are
a bit much and not enough
[ https://issues.apache.org/jira/browse/BEAM-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367133#comment-15367133 ]
ASF GitHub Bot commented on BEAM-431:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/609
[BEAM-431] Move example dependency on runners into a profile
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Even an optional runtime dependency, such as from the examples
to a runner, does get pulled in for testing. This meant that
all the dependencies for all runners had to be resolvable in an
integration testing context. It is quite inconvenient.
Explicitly excluding runners via flags such as `-pl !runners/spark`
does not work since it causes errors in dependency resolution.
This change adds a profile, active by default, that can be
explicitly disabled to avoid pulling in dependencies.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam no-runners
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/609.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #609
----
commit c17768f14f5a57bcc2d83613818101f3b21e7260
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-07-08T02:41:45Z
Move example dependency on runners into a profile
Even an optional runtime dependency, such as from the examples
to a runner, does get pulled in for testing. This meant that
all the dependencies for all runners had to be resolvable in an
integration testing context. It is quite inconvient.
Explicitly excluding runners via flags such as `-pl !runners/spark`
does not work since it causes errors in dependency resolution.
This change adds a profile, active by default, that can be
explicitly disabled to avoid pulling in dependencies.
----
> Examples dependencies on runners are a bit much and not enough
> --------------------------------------------------------------
>
> Key: BEAM-431
> URL: https://issues.apache.org/jira/browse/BEAM-431
> Project: Beam
> Issue Type: Bug
> Components: examples-java
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> The Java 7 examples directly depend on the Dataflow runner as a compile dependency. This should just be fixed and removed.
> The Java 8 examples have optional runtime dependencies on the Dataflow and Flink runners. But even optional runtime dependencies must be resolved in a test scope, so it is not possible to exclude these from a hermetic testing environment - quite annoying. And the Spark runner should be included as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)