You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <st...@dev.static-void.de> on 2016/01/02 13:43:00 UTC
Review Request 41846: Add a list of Aurora design documents
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41846/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Even though documents can become outdated after a couple of months or even years, they are an important resource for future committers.
Diffs
-----
docs/README.md 1312d704575a6c4b611d7acf16eda98b1814c78f
docs/design-documents.md PRE-CREATION
Diff: https://reviews.apache.org/r/41846/diff/
Testing
-------
Rendered version is available at https://github.com/StephanErb/aurora/blob/design-docs/docs/design-documents.md
Thanks,
Stephan Erb
Re: Review Request 41846: Add a list of Aurora design documents
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41846/#review112431
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On Jan. 2, 2016, 1:43 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41846/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 1:43 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Even though documents can become outdated after a couple of months or even years, they are an important resource for future committers.
>
>
> Diffs
> -----
>
> docs/README.md 1312d704575a6c4b611d7acf16eda98b1814c78f
> docs/design-documents.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41846/diff/
>
>
> Testing
> -------
>
> Rendered version is available at https://github.com/StephanErb/aurora/blob/design-docs/docs/design-documents.md
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 41846: Add a list of Aurora design documents
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41846/#review112430
-----------------------------------------------------------
Master (4a9f2ff) is red with this patch.
./build-support/jenkins/build.sh
src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_standard_transitions [32mPASSED[0m
src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_nonstandard_transitions [32mPASSED[0m
src/test/python/apache/thermos/observer/test_task_observer.py::TaskObserverTest::test_run_loop [31mFAILED[0m
==================== FAILURES ====================
_________ TaskObserverTest.test_run_loop _________
self = <test_task_observer.TaskObserverTest testMethod=test_run_loop>
[1m def test_run_loop(self):[0m
[1m """Test observer run loop."""[0m
[1m mock_task_detector = create_autospec(spec=ObserverTaskDetector)[0m
[1m with patch([0m
[1m "apache.thermos.observer.task_observer.ObserverTaskDetector",[0m
[1m return_value=mock_task_detector) as mock_detector:[0m
[1m with patch('threading._Event.wait') as mock_wait:[0m
[1m [0m
[1m run_count = 3[0m
[1m interval = 15[0m
[1m observer = TaskObserver(mock_detector, interval=Amount(interval, Time.SECONDS))[0m
[1m observer.start()[0m
[1m while len(mock_wait.mock_calls) < run_count:[0m
[1m pass[0m
[1m [0m
[1m observer.stop()[0m
[1m [0m
[1m> assert len(mock_task_detector.mock_calls) >= run_count[0m
[1m[31mE AssertionError: assert 1 >= 3[0m
[1m[31mE + where 1 = len([call.refresh()])[0m
[1m[31mE + where [call.refresh()] = <MagicMock spec='ObserverTaskDetector' id='139765456111376'>.mock_calls[0m
src/test/python/apache/thermos/observer/test_task_observer.py:42: AssertionError
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.observer.observer.xml
[1m[31m======= 1 failed, 3 passed in 0.25 seconds =======[0m
FAILURE
13:00:09 04:04 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 2, 2016, 12:43 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41846/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 12:43 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Even though documents can become outdated after a couple of months or even years, they are an important resource for future committers.
>
>
> Diffs
> -----
>
> docs/README.md 1312d704575a6c4b611d7acf16eda98b1814c78f
> docs/design-documents.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41846/diff/
>
>
> Testing
> -------
>
> Rendered version is available at https://github.com/StephanErb/aurora/blob/design-docs/docs/design-documents.md
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 41846: Add a list of Aurora design documents
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41846/#review112434
-----------------------------------------------------------
Ship it!
Master (4a9f2ff) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 2, 2016, 12:43 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41846/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 12:43 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Even though documents can become outdated after a couple of months or even years, they are an important resource for future committers.
>
>
> Diffs
> -----
>
> docs/README.md 1312d704575a6c4b611d7acf16eda98b1814c78f
> docs/design-documents.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41846/diff/
>
>
> Testing
> -------
>
> Rendered version is available at https://github.com/StephanErb/aurora/blob/design-docs/docs/design-documents.md
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 41846: Add a list of Aurora design documents
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41846/#review112465
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 2, 2016, 4:43 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41846/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 4:43 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Even though documents can become outdated after a couple of months or even years, they are an important resource for future committers.
>
>
> Diffs
> -----
>
> docs/README.md 1312d704575a6c4b611d7acf16eda98b1814c78f
> docs/design-documents.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41846/diff/
>
>
> Testing
> -------
>
> Rendered version is available at https://github.com/StephanErb/aurora/blob/design-docs/docs/design-documents.md
>
>
> Thanks,
>
> Stephan Erb
>
>