You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/09/21 14:33:43 UTC
[GitHub] [geode] nikochiko opened a new pull request #6888: [documentation] Align contents section in README
nikochiko opened a new pull request #6888:
URL: https://github.com/apache/geode/pull/6888
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
Came here from ApacheCon, saw this and thought I'll start my contributions here 😄
This PR adds changes to format the contents section of the README in a way that the 9th and 10th list element are not rendered on to the same line. I've also changed the numbering from 1,2,3,4 to 1,1,1,1 so that Markdown can figure out the numbering (lesser chance of missing a number in the list)
Before:
After:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on pull request #6888: [documentation] Align contents section in README
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on pull request #6888:
URL: https://github.com/apache/geode/pull/6888#issuecomment-924214493
@nikochiko Thank you for your contribution!
For tracking purposes I created a JIRA ticket for this fix. Please prepend 'GEODE-9619: ' to the title of this PR.
You can view the JIRA ticket at https://issues.apache.org/jira/projects/GEODE/issues/GEODE-9619?filter=allopenissues.
I could not locate your username in the system, so I assigned the ticket to myself for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #6888: GEODE-9619: [documentation] Align contents section in README
Posted by GitBox <gi...@apache.org>.
davebarnes97 merged pull request #6888:
URL: https://github.com/apache/geode/pull/6888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nikochiko commented on pull request #6888: [documentation] Align contents section in README
Posted by GitBox <gi...@apache.org>.
nikochiko commented on pull request #6888:
URL: https://github.com/apache/geode/pull/6888#issuecomment-924237005
Hey @davebarnes97 Thank you for reviewing the pull request.
I have added an account on Jira as well with the username `nikochiko`. (I thought it was only for Apache folks so I hadn't created an account earlier)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org