[GitHub] [echarts] Ovilia commented on a diff in pull request #16963: fix(scale): intervalTick should between extent. close 16888

[GitBox <gi...@apache.org>]

Ovilia commented on code in PR #16963:
URL: https://github.com/apache/echarts/pull/16963#discussion_r890818337


##########
src/scale/Time.ts:
##########
@@ -628,7 +628,7 @@ function getIntervalTicks(
     }
 
     const levelsTicksInExtent = filter(map(levelsTicks, levelTicks => {
-        return filter(levelTicks, tick => tick.value >= extent[0] && tick.value <= extent[1] && !tick.notAdd);
+        return filter(levelTicks, tick => tick.value > extent[0] && tick.value < extent[1] && !tick.notAdd);

Review Comment:
   This is probably not the correct place to fix the problem. For example, the min/max labels are always hidden after this changing. You need to make sure the test cases in `timeScale-formatter.html` still works the same as before changing.



##########
test/axisLabel.html:
##########
@@ -267,7 +268,7 @@
                 option = {
                     backgroundColor: '#eee',
                     title: {
-                        text: 'axisLable.formatter: {value} should be correct'
+                        text: 'axisLabel.formatter: {value} should be correct'

Review Comment:
   Related test cases should be put into `timeScale-formatter.html`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org