Re: [PR] HBASE-27795: Define RPC API for cache cleaning [hbase]

["Kota-SH (via GitHub)" <gi...@apache.org>]

Kota-SH commented on PR #5525:
URL: https://github.com/apache/hbase/pull/5525#issuecomment-1836612742

   @Apache9 - Thanks for the review. 
   
   > What will happen if the region is moved back while we are cleaning its blocks in block cache?
       As of now, we check the region state before calling evictBlocksByHfileName() method in uncacheStaleBlocks(). So we only evict blocks if the region state isClosed/isClosing. If the region is moved back, it will be in a different state, and we do not evict its blocks.
   
   > What about other types of BlockCache?
       Currently, we only support BucketCache and CombinedBlockCache. We can extend this feature to other types of block cache if required. I can create a separate jira to handle those scenarios. 
   
   > I prefer here we pass an interface / If we do not clean any blocks, just return an empty map?
       Yes, we pass an empty map if we don't evict any blocks. I made the change to pass an Interface in a separate PR to the master branch (https://github.com/apache/hbase/pull/5492). Could you please review it there? 
   
   Thanks, 
   Shanmukha K
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org