You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/08/07 11:56:00 UTC
[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

rombert commented on pull request #18:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-670480617


   This still needs work, there are a number of failures in the Sling ITs
   
   ```
   [ERROR] Tests run: 62, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 35.074 s <<< FAILURE! - in org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest
   [ERROR] testMapNamespaceMangling(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest)  Time elapsed: 0.612 s  <<< FAILURE!
   org.junit.ComparisonFailure: Expect unmangled path expected:</[]sample> but was:</[virtual/]sample>
   	at org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testMapNamespaceMangling(ResourceResolverGeneralTest.java:2089)
   
   [ERROR] testResolveVirtualHostHttp80Multiple(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest)  Time elapsed: 0.581 s  <<< FAILURE!
   org.junit.ComparisonFailure: expected:<[http://de.host.com]/playground.html> but was:<[/de]/playground.html>
   	at org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testResolveVirtualHostHttp80Multiple(ResourceResolverGeneralTest.java:716)
   
   [ERROR] testResolveVirtualHostHttp8080(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest)  Time elapsed: 0.575 s  <<< FAILURE!
   org.junit.ComparisonFailure: expected:<[http://virtual.host.com:8080]/playground.html> but was:<[/virtual]/playground.html>
   	at org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testResolveVirtualHostHttp8080(ResourceResolverGeneralTest.java:880)
   
   [ERROR] testResolveVirtualHostHttps443(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest)  Time elapsed: 0.568 s  <<< FAILURE!
   org.junit.ComparisonFailure: expected:<[https://virtual.host.com]/playground.html> but was:<[/virtual]/playground.html>
   	at org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testResolveVirtualHostHttps443(ResourceResolverGeneralTest.java:950)
   
   [ERROR] testResolveVirtualHostHttps4443(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest)  Time elapsed: 0.563 s  <<< FAILURE!
   org.junit.ComparisonFailure: expected:<[https://virtual.host.com:4443]/playground.html> but was:<[/virtual]/playground.html>
   	at org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testResolveVirtualHostHttps4443(ResourceResolverGeneralTest.java:984)
   
   [ERROR] testMapURLEscaping(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest)  Time elapsed: 0.581 s  <<< FAILURE!
   org.junit.ComparisonFailure: expected:<[http://internal.host.com]/sample%20with%20spa...> but was:<[/internal]/sample%20with%20spa...>
   	at org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testMapURLEscaping(ResourceResolverGeneralTest.java:2029)
   
   [ERROR] testResolveResourceInternalRedirectExact(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest)  Time elapsed: 0.55 s  <<< FAILURE!
   org.junit.ComparisonFailure: expected:<[https://localhost/virtua]l> but was:<[/virtual.htm]l>
   	at org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testResolveResourceInternalRedirectExact(ResourceResolverGeneralTest.java:600)
   
   [ERROR] testResolveVirtualHostHttp80(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest)  Time elapsed: 0.561 s  <<< FAILURE!
   org.junit.ComparisonFailure: expected:<[http://virtual.host.com]/playground.html> but was:<[/virtual]/playground.html>
   	at org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testResolveVirtualHostHttp80(ResourceResolverGeneralTest.java:667)
   
   [ERROR] testResolveVirtualHostHttpVsHttps(org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest)  Time elapsed: 0.555 s  <<< FAILURE!
   org.junit.ComparisonFailure: expected:<[http://www.host.com]/playground.html> but was:<[/page]/playground.html>
   	at org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest.testResolveVirtualHostHttpVsHttps(ResourceResolverGeneralTest.java:1043)
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org