You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Cheolsoo Park (Created) (JIRA)" <ji...@apache.org> on 2012/03/09 02:43:57 UTC
[jira] [Created] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Remove redundant steps in compatibility tests: verifyReadback() method
----------------------------------------------------------------------
Key: SQOOP-459
URL: https://issues.apache.org/jira/browse/SQOOP-459
Project: Sqoop
Issue Type: Improvement
Reporter: Cheolsoo Park
Assignee: Cheolsoo Park
Priority: Minor
Several tests including ManagerCompatTest do the following:
1) Tests insert data
2) Compare output from the db against inserted values
3) Run Sqoop import jobs
4) Compare output read from seq files against inserted values
Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "Cheolsoo Park (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated SQOOP-459:
--------------------------------
Attachment: SQOOP-459.patch
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
> Attachments: SQOOP-459.patch
>
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "Cheolsoo Park (Work started) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on SQOOP-459 started by Cheolsoo Park.
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
> Attachments: SQOOP-459.patch
>
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226432#comment-13226432 ]
jiraposter@reviews.apache.org commented on SQOOP-459:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4266/#review5800
-----------------------------------------------------------
Ship it!
Thanks for the patch!
- Bilung
On 2012-03-09 19:38:14, Cheolsoo Park wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4266/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-09 19:38:14)
bq.
bq.
bq. Review request for Sqoop and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Several tests including ManagerCompatTest do the following:
bq.
bq. 1) Tests insert data
bq. 2) Compare output from the db against inserted values
bq. 3) Run Sqoop import jobs
bq. 4) Compare output read from seq files against inserted values
bq.
bq. Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
bq.
bq. Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
bq.
bq.
bq. This addresses bug SQOOP-459.
bq. https://issues.apache.org/jira/browse/SQOOP-459
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661
bq. ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661
bq. ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661
bq. ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661
bq. ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661
bq. ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661
bq.
bq. Diff: https://reviews.apache.org/r/4266/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran
bq. ant test
bq. ant test -Dthirdparty
bq. ant checkstyle
bq.
bq.
bq. Thanks,
bq.
bq. Cheolsoo
bq.
bq.
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "Cheolsoo Park (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated SQOOP-459:
--------------------------------
Fix Version/s: 1.4.2-incubating
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
> Labels: patch
> Fix For: 1.4.2-incubating
>
> Attachments: SQOOP-459.patch
>
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work stopped] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "Cheolsoo Park (Work stopped) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on SQOOP-459 stopped by Cheolsoo Park.
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
> Attachments: SQOOP-459.patch
>
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226534#comment-13226534 ]
Hudson commented on SQOOP-459:
------------------------------
Integrated in Sqoop-ant-jdk-1.6 #95 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6/95/])
SQOOP-459 Remove redundant steps in compatibility tests: verifyReadback() method (Revision 1299056)
Result = SUCCESS
blee : http://svn.apache.org/viewvc/?view=rev&rev=1299056
Files :
* /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestColumnTypes.java
* /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestMultiCols.java
* /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java
* /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java
* /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java
* /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
> Labels: patch
> Fix For: 1.4.2-incubating
>
> Attachments: SQOOP-459.patch
>
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225774#comment-13225774 ]
jiraposter@reviews.apache.org commented on SQOOP-459:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4266/
-----------------------------------------------------------
Review request for Sqoop and Bilung Lee.
Summary
-------
Several tests including ManagerCompatTest do the following:
1) Tests insert data
2) Compare output from the db against inserted values
3) Run Sqoop import jobs
4) Compare output read from seq files against inserted values
Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
This addresses bug SQOOP-459.
https://issues.apache.org/jira/browse/SQOOP-459
Diffs
-----
./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661
./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661
./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661
./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661
./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661
./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661
Diff: https://reviews.apache.org/r/4266/diff
Testing
-------
Thanks,
Cheolsoo
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "Bilung Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilung Lee updated SQOOP-459:
-----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed. Thanks, Cheolsoo!
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
> Labels: patch
> Attachments: SQOOP-459.patch
>
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "Cheolsoo Park (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated SQOOP-459:
--------------------------------
Status: Patch Available (was: Open)
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
> Labels: patch
> Attachments: SQOOP-459.patch
>
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-459) Remove redundant steps in
compatibility tests: verifyReadback() method
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226374#comment-13226374 ]
jiraposter@reviews.apache.org commented on SQOOP-459:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4266/
-----------------------------------------------------------
(Updated 2012-03-09 19:38:14.027866)
Review request for Sqoop and Bilung Lee.
Summary
-------
Several tests including ManagerCompatTest do the following:
1) Tests insert data
2) Compare output from the db against inserted values
3) Run Sqoop import jobs
4) Compare output read from seq files against inserted values
Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
This addresses bug SQOOP-459.
https://issues.apache.org/jira/browse/SQOOP-459
Diffs
-----
./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661
./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661
./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661
./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661
./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661
./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661
Diff: https://reviews.apache.org/r/4266/diff
Testing (updated)
-------
Ran
ant test
ant test -Dthirdparty
ant checkstyle
Thanks,
Cheolsoo
> Remove redundant steps in compatibility tests: verifyReadback() method
> ----------------------------------------------------------------------
>
> Key: SQOOP-459
> URL: https://issues.apache.org/jira/browse/SQOOP-459
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
>
> Several tests including ManagerCompatTest do the following:
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira