You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@guacamole.apache.org by Mike Jumper <mi...@glyptodon.com> on 2021/04/02 17:56:41 UTC
Re: Problem with TOTP registering between 1.3.0 and github/master ?
This should be fixed now on git master via
https://issues.apache.org/jira/browse/GUACAMOLE-1298
Michael Jumper
CEO, Lead Developer
Glyptodon Inc <https://glyp.to/>.
On Mon, Mar 29, 2021 at 1:27 PM Philippe MARASSE
<ph...@ch-poitiers.fr.invalid> wrote:
> Le 29/03/2021 à 18:38, Nick Couchman a écrit :
>
> On Mon, Mar 29, 2021 at 10:01 AM Philippe MARASSE
> <ph...@ch-poitiers.fr.invalid>
> <ph...@ch-poitiers.fr.invalid> wrote:
>
>> Never done a git bisect before :-) after 7 steps, its done :
>>
>> $ git bisect bad
>> f21a7c63ebc105eb26eb5adf91c8e65e1f99e014 is the first bad commit
>> commit f21a7c63ebc105eb26eb5adf91c8e65e1f99e014
>> Author: Michael Jumper <mj...@apache.org> <mj...@apache.org>
>> Date: Thu May 28 19:01:13 2020 -0700
>>
>> GUACAMOLE-1298: Migrate to latest version of Guice and Jersey 2.x
>>
>> :040000 040000 3abc05f30b6fc345a06ecd31c7c946d94bb5a687
>> bb8145256d75dc5c98e2d0ba0fbc72680e463962 M guacamole
>>
>> Luckily, the issue is straigthforward to test : no need to reset database
>> between tests, just bisect, mvn clean package, deploy, restart tomcat and
>> login.
>>
>>
> Thanks for tracking this down. I wonder if there needs to be something
> done for the extensions that provide their own REST endpoints (TOTP,
> QuickConnect, etc.)?
>
> One more request for you, Philippe - can you watch the browser network
> console to see if there's any HTTP error that occurs when trying to
> retrieve the code? I can probably spin it up myself and try it, but if
> you're able to reproduce it quickly that would be helpful.
>
> -Nick
>
> I've rebuilt commit f21a7c63, from login page to enrollment :
>
>
>
> On the last request, the answer carries the QRCode and secret :
>
> {
> "message": "TOTP enrollment must be completed before authentication can
> continue",
> "translatableMessage": {
> "key": "TOTP.INFO_ENROLL_REQUIRED",
> "variables": null
> },
> "statusCode": null,
> "expected": [
> {
> "name": "guac-totp",
> "type": "GUAC_TOTP_CODE",
> "options": null,
> "digits": 6,
> "secret": "FC5OK7YUC6MU42PNPT4NGUBBPD46GLS2",
> "username": "guacadmin",
> "period": 30,
> "issuer": "CHL TEST Telem",
> "mode": "SHA1",
> "keyURI":
> "otpauth://totp/CHL%20TEST%20Telem:guacadmin?secret=FC5OK7YUC6MU42PNPT4NGUBBPD46GLS2&issuer=CHL+TEST+Telem&algorithm=SHA1&digits=6&period=30",
> "qrcode": "data:image/png;base64,iVBORw0KGg...ErkJggg=="
> }
> ],
> "type": "INSUFFICIENT_CREDENTIALS"
> }
>
> Regards.
>
> --
> Philippe MARASSE
>
> Responsable pôle Infrastructures - DSIO
> Centre Hospitalier Henri Laborit
> CS 10587 - 370 avenue Jacques Cœur
> 86021 Poitiers Cedex
> Tel : 05.49.44.57.19
>
>
Re: Problem with TOTP registering between 1.3.0 and github/master ?
Posted by Philippe MARASSE <ph...@ch-poitiers.fr.INVALID>.
Yes, I can confirm that it works now.
Thank you.
Rgds.
Le 02/04/2021 à 19:56, Mike Jumper a écrit :
> This should be fixed now on git master
> via https://issues.apache.org/jira/browse/GUACAMOLE-1298
> <https://issues.apache.org/jira/browse/GUACAMOLE-1298>
>
> Michael Jumper
> CEO, Lead Developer
> Glyptodon Inc <https://glyp.to/>.
>
>
> On Mon, Mar 29, 2021 at 1:27 PM Philippe MARASSE
> <ph...@ch-poitiers.fr.invalid> wrote:
>
> Le 29/03/2021 à 18:38, Nick Couchman a écrit :
>> On Mon, Mar 29, 2021 at 10:01 AM Philippe MARASSE
>> <ph...@ch-poitiers.fr.invalid>
>> <ma...@ch-poitiers.fr.invalid> wrote:
>>
>> Never done a git bisect before :-) after 7 steps, its done :
>>
>> $ git bisect bad
>> f21a7c63ebc105eb26eb5adf91c8e65e1f99e014 is the first bad commit
>> commit f21a7c63ebc105eb26eb5adf91c8e65e1f99e014
>> Author: Michael Jumper <mj...@apache.org>
>> <ma...@apache.org>
>> Date: Thu May 28 19:01:13 2020 -0700
>>
>> GUACAMOLE-1298: Migrate to latest version of Guice and
>> Jersey 2.x
>>
>> :040000 040000 3abc05f30b6fc345a06ecd31c7c946d94bb5a687
>> bb8145256d75dc5c98e2d0ba0fbc72680e463962 M guacamole
>>
>> Luckily, the issue is straigthforward to test : no need to
>> reset database between tests, just bisect, mvn clean package,
>> deploy, restart tomcat and login.
>>
>>
>> Thanks for tracking this down. I wonder if there needs to be
>> something done for the extensions that provide their own REST
>> endpoints (TOTP, QuickConnect, etc.)?
>>
>> One more request for you, Philippe - can you watch the browser
>> network console to see if there's any HTTP error that occurs when
>> trying to retrieve the code? I can probably spin it up myself and
>> try it, but if you're able to reproduce it quickly that would be
>> helpful.
>>
>> -Nick
> I've rebuilt commit f21a7c63, from login page to enrollment :
>
>
>
> On the last request, the answer carries the QRCode and secret :
>
> {
> "message": "TOTP enrollment must be completed before
> authentication can continue",
> "translatableMessage": {
> "key": "TOTP.INFO_ENROLL_REQUIRED",
> "variables": null
> },
> "statusCode": null,
> "expected": [
> {
> "name": "guac-totp",
> "type": "GUAC_TOTP_CODE",
> "options": null,
> "digits": 6,
> "secret": "FC5OK7YUC6MU42PNPT4NGUBBPD46GLS2",
> "username": "guacadmin",
> "period": 30,
> "issuer": "CHL TEST Telem",
> "mode": "SHA1",
> "keyURI":
> "otpauth://totp/CHL%20TEST%20Telem:guacadmin?secret=FC5OK7YUC6MU42PNPT4NGUBBPD46GLS2&issuer=CHL+TEST+Telem&algorithm=SHA1&digits=6&period=30",
> "qrcode": "data:image/png;base64,iVBORw0KGg...ErkJggg=="
> }
> ],
> "type": "INSUFFICIENT_CREDENTIALS"
> }
>
> Regards.
>
> --
> Philippe MARASSE
>
> Responsable pôle Infrastructures - DSIO
> Centre Hospitalier Henri Laborit
> CS 10587 - 370 avenue Jacques Cœur
> 86021 Poitiers Cedex
> Tel : 05.49.44.57.19
>
--
Philippe MARASSE
Responsable pôle Infrastructures - DSIO
Centre Hospitalier Henri Laborit
CS 10587 - 370 avenue Jacques Cœur
86021 Poitiers Cedex
Tel : 05.49.44.57.19