[jira] [Commented] (WW-4313) freemaker Checkboxlist not rendering id correctly

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14045866#comment-14045866 ] 

Hudson commented on WW-4313:
----------------------------

SUCCESS: Integrated in Struts-JDK6-features #65 (See [https://builds.apache.org/job/Struts-JDK6-features/65/])
WW-4313 Uses name instead of id if the other isn't set (lukaszlenart: rev 9a94699da0f1044cf0dad1acd717fccb715e45ea)
* core/src/main/resources/template/simple/checkboxlist.ftl


> freemaker Checkboxlist not rendering id correctly
> -------------------------------------------------
>
>                 Key: WW-4313
>                 URL: https://issues.apache.org/jira/browse/WW-4313
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions
>    Affects Versions: 2.3.16.1
>         Environment: Tomcat/centos
>            Reporter: Greg Huber
>            Assignee: Greg Huber
>            Priority: Minor
>             Fix For: 2.3.18
>
>         Attachments: struts.patch
>
>
> The existing code:
> {code:xml}
> <input type="checkbox" name="${parameters.name?html}" value="${itemKeyStr?html}"
>        id="${parameters.name?html}-${itemCount}"<#rt/>
> {code}
> needs to check for the id before adding the name ie:
> {code:xml}
> <input type="checkbox" name="${parameters.name?html}" value="${itemKeyStr?html}"<#rt/>
>     <#if parameters.id??>
>        id="${parameters.id?html}-${itemCount}"<#rt/>
>     <#else>
>        id="${parameters.name?html}-${itemCount}"<#rt/>
>     </#if>
> {code}
> Also the label needs the mods also:
> from:
> {code:xml}
> <label for="${parameters.name?html}-${itemCount}" class="checkboxLabel">${itemValue?html}</label>
> {code}
> to:
> {code:xml}
> <label<#rt/> 
>     <#if parameters.id??>
>         for="${parameters.id?html}-${itemCount}"<#rt/>
>     <#else>
>         for="${parameters.name?html}-${itemCount}"<#rt/>
>     </#if>
>         class="checkboxLabel">${itemValue?html}</label>
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)