You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/21 15:57:07 UTC

[GitHub] [spark] srowen commented on a change in pull request #29824: [SPARK-32954][YARN][TEST] Add jakarta.servlet-api test dependency to yarn module to avoid UTs badcase

srowen commented on a change in pull request #29824:
URL: https://github.com/apache/spark/pull/29824#discussion_r492172135



##########
File path: resource-managers/yarn/pom.xml
##########
@@ -88,6 +88,13 @@
       <artifactId>hadoop-client</artifactId>
     </dependency>
 
+    <dependency>
+      <groupId>jakarta.servlet</groupId>
+      <artifactId>jakarta.servlet-api</artifactId>
+      <version>4.0.3</version>
+      <scope>test</scope>
+    </dependency>
+

Review comment:
       How about instead excluding the 4.0.x dependency from wherever it comes in? My guess is we want the 3.x version.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org