You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/05/02 14:24:40 UTC

[kudu-CR] KUDU-1433: check stat validity before dumping mm ops

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2922

to review the following change.

Change subject: KUDU-1433: check stat validity before dumping mm ops
......................................................................

KUDU-1433: check stat validity before dumping mm ops

Some mm ops don't cache their stats, and in doing so, can yield invalid
stats following a call to FindBestOp(). Users of these stats need to be
aware that they may be invalid, and to protect themselves accordingly. In
this particular case, I think it makes more sense to provide zeroed stats
than to skip the op altogether.

After modifying the PeriodicWebUIChecker to access /maintenance-manager,
linked_list-test failed 100% of the time. With the fix, it doesn't fail.

Change-Id: I4c363c8b1adb9724a2c1deb09a27a7d89d84c270
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/tablet/maintenance_manager.cc
2 files changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/2922/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c363c8b1adb9724a2c1deb09a27a7d89d84c270
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>