You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/17 18:35:22 UTC
[GitHub] [shardingsphere-elasticjob] terrymanu opened a new issue #1116: Adjust spring module structure
terrymanu opened a new issue #1116:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1116
The current spring module structure is not good enough after we add the spring boot starter module.
The current structure is:
```
--elasticjob-lite-spring
--elasticjob-lite-spring-boot-starter
```
How about adjust them to:
```
--elasticjob-lite-spring
----elasticjob-lite-spring-boot-starter
----elasticjob-lite-spring-namespace
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu commented on issue #1116: Adjust spring module structure
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #1116:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1116#issuecomment-660589660
@cocodroid,
Hi, I add some code review for your pr, please fix them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] cocodroid commented on issue #1116: Adjust spring module structure
Posted by GitBox <gi...@apache.org>.
cocodroid commented on issue #1116:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1116#issuecomment-660311151
Please assign it to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu commented on issue #1116: Adjust spring module structure
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #1116:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1116#issuecomment-660820920
@cocodroid Sorry, I need to revert your pr, because this pr do not move the spring boot's test cases, and the test cases are missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu edited a comment on issue #1116: Adjust spring module structure
Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on issue #1116:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1116#issuecomment-660589660
@cocodroid,
Hi, I add some code review suggestions for your pr, please fix them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu closed issue #1116: Adjust spring module structure
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #1116:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu closed issue #1116: Adjust spring module structure
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #1116:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] cocodroid commented on issue #1116: Adjust spring module structure
Posted by GitBox <gi...@apache.org>.
cocodroid commented on issue #1116:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1116#issuecomment-660478537
Finish
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] cocodroid commented on issue #1116: Adjust spring module structure
Posted by GitBox <gi...@apache.org>.
cocodroid commented on issue #1116:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1116#issuecomment-660613914
@terrymanu
Sorry, I ignored it. I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org