You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/03/23 13:22:36 UTC
[kudu-CR] KUDU-2232. java: Remove deprecated call from KuduTable
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/8749 )
Change subject: KUDU-2232. java: Remove deprecated call from KuduTable
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8749/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java:
http://gerrit.cloudera.org:8080/#/c/8749/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@212
PS2, Line 212: /**
: * Retrieves a formatted representation of this table's range partitions. The
: * range partitions will be returned in sorted order by value, and will
: * contain no duplicates.
: *
: * @param deadline the deadline of the operation
: * @return a list of the formatted range partitions
: */
> Add a comment that this was replaced by the call below.
thanks, I'm not going to replace it after all
http://gerrit.cloudera.org:8080/#/c/8749/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@223
PS2, Line 223: public List<String> getFormattedRangePartitions(long deadline) throws Exception {
> isn't this a breaking change, in that the deadline is now ignored?
Ack
--
To view, visit http://gerrit.cloudera.org:8080/8749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c54d0483241166675c65a8002464d4bd9604a4f
Gerrit-Change-Number: 8749
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 23 Mar 2018 13:22:36 +0000
Gerrit-HasComments: Yes