You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/05/28 02:37:20 UTC

[GitHub] carbondata pull request #2345: [WIP] Improve Carbon Reader Schema reading pe...

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2345#discussion_r191100739
  
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
    @@ -101,6 +108,43 @@ public static CarbonReaderBuilder builder(String tablePath, String tableName) {
         return reader.readSchema();
       }
     
    +  /**
    +   * Read carbonindex file and return the schema
    +   * @param indexFilePath complete path including index file name
    +   * @return null, if the index file is not present in the path.
    --- End diff --
    
    Can you optimize the expression? and can you add test case for returning null if the index file is not present in the path?


---