You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/01/31 22:53:58 UTC

[jira] [Created] (LUCENE-3741) MockCharFilter offset correction is wrong

MockCharFilter offset correction is wrong
-----------------------------------------

                 Key: LUCENE-3741
                 URL: https://issues.apache.org/jira/browse/LUCENE-3741
             Project: Lucene - Java
          Issue Type: Bug
          Components: general/test
    Affects Versions: 3.6, 4.0
            Reporter: Robert Muir
         Attachments: LUCENE-3741.patch

This is a fake charfilter used in basetokenstreamtestcase.

it occasionally doubles some characters, and corrects offsets.

its used to find bugs where analysis components would fail otherwise with charfilters,
but its correctOffset is actually wrong (harmless to any tests today, but still wrong).


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3741) MockCharFilter offset correction is wrong

Posted by "Robert Muir (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-3741.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
                   3.6
    
> MockCharFilter offset correction is wrong
> -----------------------------------------
>
>                 Key: LUCENE-3741
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3741
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/test
>    Affects Versions: 3.6, 4.0
>            Reporter: Robert Muir
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3741.patch
>
>
> This is a fake charfilter used in basetokenstreamtestcase.
> it occasionally doubles some characters, and corrects offsets.
> its used to find bugs where analysis components would fail otherwise with charfilters,
> but its correctOffset is actually wrong (harmless to any tests today, but still wrong).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3741) MockCharFilter offset correction is wrong

Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3741:
--------------------------------

    Attachment: LUCENE-3741.patch

stupid bug.

I added assertions to MockTokenizer that no charfilters "go backwards" and some basic bounds checking on their correctOffsets... all other tests pass.

                
> MockCharFilter offset correction is wrong
> -----------------------------------------
>
>                 Key: LUCENE-3741
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3741
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/test
>    Affects Versions: 3.6, 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3741.patch
>
>
> This is a fake charfilter used in basetokenstreamtestcase.
> it occasionally doubles some characters, and corrects offsets.
> its used to find bugs where analysis components would fail otherwise with charfilters,
> but its correctOffset is actually wrong (harmless to any tests today, but still wrong).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org