You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/02/03 09:47:27 UTC
[GitHub] [parquet-mr] gszadovszky opened a new pull request #862: PARQUET-1969: FOLLOWUP: Remove/exchange Travis related references
gszadovszky opened a new pull request #862:
URL: https://github.com/apache/parquet-mr/pull/862
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #862: PARQUET-1969: FOLLOWUP: Remove/exchange Travis related references
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #862:
URL: https://github.com/apache/parquet-mr/pull/862#issuecomment-775766817
Close/re-open to trigger tests.
@shangxinli, if you have time could you please review this? The release is blocked on this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #862: PARQUET-1969: FOLLOWUP: Remove/exchange Travis related references
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #862:
URL: https://github.com/apache/parquet-mr/pull/862#issuecomment-772403832
Thanks @wangyum. Already create PARQUET-1971 about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky closed pull request #862: PARQUET-1969: FOLLOWUP: Remove/exchange Travis related references
Posted by GitBox <gi...@apache.org>.
gszadovszky closed pull request #862:
URL: https://github.com/apache/parquet-mr/pull/862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wangyum commented on pull request #862: PARQUET-1969: FOLLOWUP: Remove/exchange Travis related references
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #862:
URL: https://github.com/apache/parquet-mr/pull/862#issuecomment-772394921
It seems we have a flaky test:
```
2021-02-03T10:07:28.9193998Z Failed tests: testMemoryManagerUpperLimit(org.apache.parquet.hadoop.TestMemoryManager): Pool size should be within 10% of the expected value (expected = 453745044 actual = 503054330)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #862: PARQUET-1969: FOLLOWUP: Remove/exchange Travis related references
Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #862:
URL: https://github.com/apache/parquet-mr/pull/862#issuecomment-775986059
LGTM!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky edited a comment on pull request #862: PARQUET-1969: FOLLOWUP: Remove/exchange Travis related references
Posted by GitBox <gi...@apache.org>.
gszadovszky edited a comment on pull request #862:
URL: https://github.com/apache/parquet-mr/pull/862#issuecomment-772403832
Thanks @wangyum. Already created PARQUET-1971 about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky merged pull request #862: PARQUET-1969: FOLLOWUP: Remove/exchange Travis related references
Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #862:
URL: https://github.com/apache/parquet-mr/pull/862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org