You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jiayi Liao (Jira)" <ji...@apache.org> on 2020/05/21 05:44:00 UTC
[jira] [Commented] (FLINK-17816) Change Latency Marker to work with
"scheduleAtFixedDelay" instead of "scheduleAtFixedRate"
[ https://issues.apache.org/jira/browse/FLINK-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112813#comment-17112813 ]
Jiayi Liao commented on FLINK-17816:
------------------------------------
I guess the change would be simple. We might just need to replace {{scheduleAtFixedRate}} with {{registerTimer}} in `LatencyMarksEmitter` like this: https://github.com/Jiayi-Liao/flink/commit/7f876d6d2a8fe8fc75a41ff17a0c84141f712af6
> Change Latency Marker to work with "scheduleAtFixedDelay" instead of "scheduleAtFixedRate"
> ------------------------------------------------------------------------------------------
>
> Key: FLINK-17816
> URL: https://issues.apache.org/jira/browse/FLINK-17816
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Task
> Reporter: Stephan Ewen
> Priority: Major
>
> Latency Markers and other periodic timers are scheduled with {{scheduleAtFixedRate}}. That means every X time the callable is called. If it blocks (backpressure) is can be called immediately again.
> I would suggest to switch this to {{scheduleAtFixedDelay}} to avoid calling for a lot of latency marker injections when there is no way to actually execute the injection call.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)