You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tomasz Janiszewski <ja...@gmail.com> on 2016/04/27 11:46:40 UTC

Review Request 46730: Cleanup syscalls logic.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.


Bugs: MESOS-5263
    https://issues.apache.org/jira/browse/MESOS-5263


Repository: mesos


Description
-------

Cleanup syscalls logic.


Diffs
-----

  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
  src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
  src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 

Diff: https://reviews.apache.org/r/46730/diff/


Testing
-------


Thanks,

Tomasz Janiszewski

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Tomasz Janiszewski <ja...@gmail.com>.

> On April 27, 2016, 10:30 a.m., haosdent huang wrote:
> > src/linux/cgroups.cpp, line 28
> > <https://reviews.apache.org/r/46730/diff/1/?file=1363062#file1363062line28>
> >
> >     I think we don't need change `cgroups.cpp`, right?
> >     
> >     Not yours, could you change the header files order like
> >     
> >     ```
> >     #include <glog/logging.h>
> >     
> >     #include <linux/unistd.h>
> >     
> >     #include <sys/types.h>
> >     ```

That's right, changes in `cgropus.cpp` are not necessary but I think it will be consitent if all syscalls were taken from one place `<linux/unistd.h>`


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130755
-----------------------------------------------------------


On April 27, 2016, 9:46 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 9:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleanup syscalls logic.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130755
-----------------------------------------------------------



I think need update the summary and the description as well. For example,

```
Used `<linux/unistd.h>` and clean up uncessary condition complie.
```

However, I am not a native speaker, this is up to you. :-)


src/linux/cgroups.cpp (line 27)
<https://reviews.apache.org/r/46730/#comment194633>

    I think we don't need change `cgroups.cpp`, right?
    
    Not yours, could you change the header files order like
    
    ```
    #include <glog/logging.h>
    
    #include <linux/unistd.h>
    
    #include <sys/types.h>
    ```



src/linux/ns.hpp (line 26)
<https://reviews.apache.org/r/46730/#comment194634>

    Add a line above.


- haosdent huang


On April 27, 2016, 9:46 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 9:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleanup syscalls logic.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by haosdent huang <ha...@gmail.com>.

> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > src/linux/cgroups.cpp, line 29
> > <https://reviews.apache.org/r/46730/diff/2/?file=1363198#file1363198line29>
> >
> >     Hm.. where is this header located?
> >     
> >     I'd expect to find a unistd.h here:
> >     https://github.com/apache/mesos/tree/master/src/linux
> 
> Bing Li wrote:
>     I think usually you can find it in /usr/include/linux/ if you have the package like "kernel-devel" installed.

For CentOS, it comes from `kernel-headers`.
```
$ rpm -qf /usr/include/linux/unistd.h
kernel-headers-3.10.0-327.13.1.el7.x86_64
yum install -y kernel-headers
```

For Ubuntu, it comes from `linux-libc-dev`.
```
dpkg -S /usr/include/linux/unistd.h
linux-libc-dev: /usr/include/linux/unistd.h
apt-get install -y linux-libc-dev
```

Should we document this?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130831
-----------------------------------------------------------


On April 27, 2016, 11:44 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Tomasz Janiszewski <ja...@gmail.com>.

> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > Could you also update the testing section? How did you ensure this compiles on the affected architectures?

What do you mean by "testing section"? Unfortunatelly I've only tested it on ARM and x86_64


> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > src/linux/ns.hpp, lines 161-162
> > <https://reviews.apache.org/r/46730/diff/2/?file=1363200#file1363200line161>
> >
> >     This looks like a similar change but it would be great to split it into a separate patch. It's not immediately obvious to me why `SYS_setns` is being changed in favor of `__NR_setns`. Can you add some some background information in the review description?
> 
> haosdent huang wrote:
>     +1 For only change `__NR_pivot_root` and update `__NR_setns` in a separate patch. I think why @janisz update to `__NR_setns` here is because he want to keep consistent as he mentioned above.

`SYS_setns` comes from glibc I (and in fact it's map for `__NR_setns`) becouse I see condition for old glibc and thought it could be replaced with kernel macro. Reverted my change


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130831
-----------------------------------------------------------


On April 29, 2016, 8:11 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 8:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by haosdent huang <ha...@gmail.com>.

> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > src/linux/ns.hpp, lines 161-162
> > <https://reviews.apache.org/r/46730/diff/2/?file=1363200#file1363200line161>
> >
> >     This looks like a similar change but it would be great to split it into a separate patch. It's not immediately obvious to me why `SYS_setns` is being changed in favor of `__NR_setns`. Can you add some some background information in the review description?

+1 For only change `__NR_pivot_root` and update `__NR_setns` in a separate patch. I think why @janisz update to `__NR_setns` here is because he want to keep consistent as he mentioned above.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130831
-----------------------------------------------------------


On April 27, 2016, 11:44 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Bing Li <bi...@gmail.com>.

> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > src/linux/cgroups.cpp, line 29
> > <https://reviews.apache.org/r/46730/diff/2/?file=1363198#file1363198line29>
> >
> >     Hm.. where is this header located?
> >     
> >     I'd expect to find a unistd.h here:
> >     https://github.com/apache/mesos/tree/master/src/linux

I think usually you can find it in /usr/include/linux/ if you have the package like "kernel-devel" installed.


- Bing


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130831
-----------------------------------------------------------


On April 27, 2016, 11:44 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130831
-----------------------------------------------------------



Could you also update the testing section? How did you ensure this compiles on the affected architectures?


src/linux/cgroups.cpp (line 25)
<https://reviews.apache.org/r/46730/#comment194729>

    Hm.. where is this header located?
    
    I'd expect to find a unistd.h here:
    https://github.com/apache/mesos/tree/master/src/linux



src/linux/ns.hpp (lines 160 - 161)
<https://reviews.apache.org/r/46730/#comment194730>

    This looks like a similar change but it would be great to split it into a separate patch. It's not immediately obvious to me why `SYS_setns` is being changed in favor of `__NR_setns`. Can you add some some background information in the review description?


- Ben Mahler


On April 27, 2016, 11:44 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130767
-----------------------------------------------------------


Ship it!




Ship It!

- haosdent huang


On April 27, 2016, 11:44 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130769
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46730]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 27, 2016, 11:44 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131070
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46730]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 8:11 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 8:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131157
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46730]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 1:03 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 1:03 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Tomasz Janiszewski <ja...@gmail.com>.

> On Kwi 30, 2016, 2:55 po południu, haosdent huang wrote:
> > As I checked with @bingli1000 and @zhiwei via email before, this works in powerpc and IBM System z. Free feel to list your concerns about test :-). cc @bmahler and @janisz
> 
> haosdent huang wrote:
>     By the way, I think the `Summary` is not clear and exactly. I think need to rephrase it when submit it.

How about 
- summary:

> Cleanup platform specific syscall conditions. 

- description:

> Use syscall defines from `<linux/unistd.h>` instead of glibc to handle different platforms without platform conditions.


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131253
-----------------------------------------------------------


On Kwi 29, 2016, 1:03 po południu, Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated Kwi 29, 2016, 1:03 po południu)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by haosdent huang <ha...@gmail.com>.

> On April 30, 2016, 2:55 p.m., haosdent huang wrote:
> > As I checked with @bingli1000 and @zhiwei via email before, this works in powerpc and IBM System z. Free feel to list your concerns about test :-). cc @bmahler and @janisz

By the way, I think the `Summary` is not clear and exactly. I think need to rephrase it when submit it.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131253
-----------------------------------------------------------


On April 29, 2016, 1:03 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 1:03 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131253
-----------------------------------------------------------


Ship it!




As I checked with @bingli1000 and @zhiwei via email before, this works in powerpc and IBM System z. Free feel to list your concerns about test :-). cc @bmahler and @janisz

- haosdent huang


On April 29, 2016, 1:03 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 1:03 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/
-----------------------------------------------------------

(Updated April 29, 2016, 1:03 p.m.)


Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.


Bugs: MESOS-5263
    https://issues.apache.org/jira/browse/MESOS-5263


Repository: mesos


Description
-------

Used `<linux/unistd.h>` and removed uncessary condition complie.


Diffs (updated)
-----

  src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 

Diff: https://reviews.apache.org/r/46730/diff/


Testing
-------


Thanks,

Tomasz Janiszewski

Re: Review Request 46730: Cleanup syscalls logic.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review131077
-----------------------------------------------------------




src/linux/cgroups.cpp 
<https://reviews.apache.org/r/46730/#comment195029>

    May you revert the changes in `cgroups.cpp` as well, we could do this in a sperate patch. In additional, we need update the `Summary` and `Description` to make them more excactly.


- haosdent huang


On April 29, 2016, 8:11 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 8:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/
-----------------------------------------------------------

(Updated April 29, 2016, 8:11 a.m.)


Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.


Bugs: MESOS-5263
    https://issues.apache.org/jira/browse/MESOS-5263


Repository: mesos


Description
-------

Used `<linux/unistd.h>` and removed uncessary condition complie.


Diffs (updated)
-----

  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
  src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 

Diff: https://reviews.apache.org/r/46730/diff/


Testing
-------


Thanks,

Tomasz Janiszewski

Re: Review Request 46730: Cleanup syscalls logic.

Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/
-----------------------------------------------------------

(Updated April 27, 2016, 11:44 a.m.)


Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.


Bugs: MESOS-5263
    https://issues.apache.org/jira/browse/MESOS-5263


Repository: mesos


Description (updated)
-------

Used `<linux/unistd.h>` and removed uncessary condition complie.


Diffs (updated)
-----

  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
  src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
  src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 

Diff: https://reviews.apache.org/r/46730/diff/


Testing
-------


Thanks,

Tomasz Janiszewski