You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/11 09:43:33 UTC

[GitHub] [apisix] zhengwe opened a new pull request #6582: delete content, consistent with en/jwt.auth.md

zhengwe opened a new pull request #6582:
URL: https://github.com/apache/apisix/pull/6582


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the PR manners:
   1. Use Draft if the PR is not ready to be reviewed
   2. Test is required for the feat/fix PR, unless you have a good reason
   3. Doc is required for the feat PR
   4. Use a new commit to resolve review instead of `push -f`
   5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
   6. Use "request review" to notify the reviewer once you have resolved the review
   7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
   -->
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] zhengwe removed a comment on pull request #6582: delete content, consistent with en/jwt.auth.md

Posted by GitBox <gi...@apache.org>.
zhengwe removed a comment on pull request #6582:
URL: https://github.com/apache/apisix/pull/6582#issuecomment-1064948823


   delete content, consistent with en/jwt.auth.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #6582: docs: polishing jwt-auth plugin's docs

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #6582:
URL: https://github.com/apache/apisix/pull/6582#issuecomment-1066227540


   Let's merge master to make CI pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #6582: docs: polishing jwt-auth plugin's docs

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6582:
URL: https://github.com/apache/apisix/pull/6582#discussion_r828198218



##########
File path: docs/zh/latest/plugins/openid-connect.md
##########
@@ -57,8 +57,8 @@ OAuth 2 / Open ID Connect（OIDC）插件为 APISIX 提供身份验证和自省
 
 ![token introspection](../../../assets/images/plugin/oauth-1.png)
 
-以下是 curl 命令，用于将插件启用到外部服务。

Review comment:
       Please keep the change from the master:
   https://github.com/apache/apisix/blob/master/docs/zh/latest/plugins/openid-connect.md




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] zhengwe commented on pull request #6582: delete content, consistent with en/jwt.auth.md

Posted by GitBox <gi...@apache.org>.
zhengwe commented on pull request #6582:
URL: https://github.com/apache/apisix/pull/6582#issuecomment-1064948823


   delete content, consistent with en/jwt.auth.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #6582: docs: polishing jwt-auth plugin's docs

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #6582:
URL: https://github.com/apache/apisix/pull/6582#issuecomment-1069303018


   Let's merge master to make CI pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org